Tweak label for Latest Posts excerpt control #49077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Copy
|
Size Change: -4 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
I actually like it the other way around. MAX NUMBER OF WORDS -> MAX NUMBER OF WORDS IN EXCERPT (But please turn off the all caps used, and instead use sentence form. "Max number of words in excerpt" Case: Image block. Has/had Image size controls. These could be called Size as it is inside the Image block, but it is called Image Size. |
|
We already have "Show > Excerpt" — I don't think we also need to reference the excerpt in the length control. It also only renders when Show > Excerpt is enabled. |
|
Also a fan of the reduction here. Speaking of less to read, should the "Post Content settings" also be just "Settings"? "Post Content" is implied by the block title at the top of the inspector. |
Good point! Ps |
Perhaps — I had some follow-up thoughts on how the Post Excerpt block experience could be improved here: #44964 (comment). Some of that could persist for the Latest Posts excerpt as well, with the exception of the editing. |
|
Related to Joen's comment.
Perhaps the word "settings" can be removed from the various panels? |
Already on it ;) |
talldan
approved these changes
Mar 15, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add consistency between the Latest Posts excerpt length control and the control added recently to the Post Excerpt block (#44964).
Why?
Consistency.
How?
Minor text string change.
Testing Instructions
Screenshots or screencast
Before:
After: