Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github-Actions-Workflows][Plugin-Release] Allow shipping a point-release for an older stable release #49082
[Github-Actions-Workflows][Plugin-Release] Allow shipping a point-release for an older stable release #49082
Changes from 22 commits
8cd1231
d685abb
8b939f8
ff5c80f
489aa70
9dc4b39
7438230
237fd16
8934253
0b06966
2cb1260
1b0713b
7ac820e
b35880a
a81bc68
60c465a
a370648
cd9bf15
e5e5764
4297be6
014e2c6
dda3c46
cade53d
fe8b33c
a37623b
ac78cac
da46aba
b6a2f82
86f4168
eae536a
d642211
472262e
fae69ef
6206fc7
b2bde7d
73a5fc4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will revert this change before merging (from
GITHUB_TOKEN
->GUTENBERG_TOKEN
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely not for this PR, but in a follow-up, can we maybe replace this with the
semver
npm? I'm already using it in a few places in the build-plugin workflow (e.g.) to compute version numbers, and it also supports comparison(and cleanup:
semver.clean(' =v1.2.3 ') // '1.2.3'
).(
dpkg
is a Debian/Ubuntu tool IIRC, and I've tried to avoid bash-isms and other dependencies as much as possible in order to make local testing of individual steps from workflows at least a bit easier across platforms -- including MacOS.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I'll take note of that for a follow-up 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before,
STABLE_TAG
was based on the value ofsteps.get_previous_stable_version.outputs.stable_version
, which for me looked a bit confusing, given theget_previous_stable_version
step -- we actually want the current latest version, and not the previous, and we can get that from theVERSION
env variable, defined as anenv
variable for the job and passed as part of the payload for therelease
event.