Replace "Image size" with "Resolution" in image size controls #49112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Type] Copy
richtabor
requested review from
a team and
paaljoachim
and removed request for
geriux
|
Size Change: +1.03 kB (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1c63528. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4501513054
|
jasmussen
approved these changes
Mar 16, 2023
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Following up on #49074, and inline with #48618 (comment), this PR replaces the "Image Size" label with "Resolution" throughout the relative block controls.
Why?
Consistency. An attempt to make the control less confusing.
How?
imageSizeHelpprop to the Latest Posts "Resolution" control.Testing Instructions
Check the Block Inspector for each of these blocks, that "Resolution" is rendered, instead of "Image size":
Screenshots or screencast
Notes
imageSizeHelpvalue added — Changes image size description, as it causes confusion #48478