-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageSizeControl: Use large 40px sizes #49113
Conversation
Size Change: +14 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Flaky tests detected in 424cc0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4472666984
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, let's do it.
In your recent slew of excellent PRs, was there one that added the help text below this selector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the rogue prop on Button, this looks good to me as well 🚀
packages/block-editor/src/components/image-size-control/index.js
Outdated
Show resolved
Hide resolved
e3ed16b
to
424cc0c
Compare
What?
Updates the
SelectControl
andNumberControl
components withinImageSizeControl
to use the larger sizes.Why?
Supporting #46734.
Testing Instructions
Screenshots
Before:
After:
Notes
The 25/50/75/100/Reset buttons are omitted intentionally (#48618 (comment)).