-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Make sure the directly inserted block in the Nav block is a Page link" #49126
Revert "Make sure the directly inserted block in the Nav block is a Page link" #49126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Size Change: -8 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Flaky tests detected in ec915f2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4435416970
|
As noted in the issue, this bug was reported today during RC and can be included in a WP 6.2 RC3 package update. Thank you everyone 👏 |
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: b4631a9 |
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. See #57471. Fixes #57929. git-svn-id: https://develop.svn.wordpress.org/trunk@55568 602fd350-edb4-49c9-b593-d223f7449a82
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. See #57471. Fixes #57929. Built from https://develop.svn.wordpress.org/trunk@55568 git-svn-id: http://core.svn.wordpress.org/trunk@55080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. See #57471. Fixes #57929. Built from https://develop.svn.wordpress.org/trunk@55568 git-svn-id: https://core.svn.wordpress.org/trunk@55080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. Reviewed by SergeyBiryukov, audrasjb. Merges [55568] to the 6.2 branch. See #57471. Fixes #57929. git-svn-id: https://develop.svn.wordpress.org/branches/6.2@55570 602fd350-edb4-49c9-b593-d223f7449a82
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. Reviewed by SergeyBiryukov, audrasjb. Merges [55568] to the 6.2 branch. See #57471. Fixes #57929. Built from https://develop.svn.wordpress.org/branches/6.2@55570 git-svn-id: http://core.svn.wordpress.org/branches/6.2@55082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Reverts #48740. Fixes #49107
This change makes it too difficult to add other things to a navigation menu - as explained in #49107
We should consider the experience here as part of the broader changes being discussed in #49091