Revert: Make sticky block action on template part block #49219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
andrewserong
requested review from
jameskoster,
apeatling,
richtabor,
tellthemachines and
a team
|
Size Change: -349 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Works for me, thank you! Sorry I initially missed the perspectives on the wrapping group. These details matter and I think we'll be better served longer term by expanding the default sticky positioning on the block itself, rather than limiting it just to the group. The feature is worth it!
|
Testing. The toolbar 3 dot drop down menu has a "Detach blocks from template part". List View upon right clicking has a "Detach blocks from template part". I appologize for my ignorance... |
apeatling
approved these changes
Mar 21, 2023
13 tasks
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Revert #49085, which added in a "Make sticky" action in the block settings for the Template Part block (available within the list view and the block toolbar)
Why?
#49085 was a slightly contentious feature! 😄
While the feature intended to make it easier for a user to create a sticky header, it did so by wrapping a template part block in a Group block, and then sets that Group block to sticky. The feedback on the feature is that while this is currently the only way a user can create a sticky header within the site editor, it isn't a flow that we want to optimise for, and ideally there would be a more intuitive way for users to achieve this. See: #49085 (comment) for more discussion.
By reverting, we can give a bit more time for the design discussion to evolve, and we can try out other ideas in subsequent PRs. Let's keep the discussion going! Perhaps over in #47043.
Thanks for all the reviews, discussion, and feedback, everybody!
How?
Revert the changes in #49085.
Testing Instructions
Smoke test by opening up the site editor, and selecting a Header template part at the root of the document. In the block settings menu within both the list view and the block toolbar, you should not see "Make sticky" as an option, and you should see "Detach blocks from template part".
Double check that the removals all look okay — the added exports in
private-apis.jswere only added in the earlier PR and aren't being used anywhere else as far as I can see, so I've reverted them, too.Screenshots or screencast