-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the time to read block to be inserted multiple times #49253
Conversation
Flaky tests detected in 0883c6a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4487868973
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah especially when you want to use the block once in the main post content and then again in a query loop template we need to be able to insert it more than once.
(I still think #38958 would make sense for this at some point :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I can't remember why I set multiple
to false
when I created this block in #43403, but I see no reason to limit it 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The PR needs to be rebased because there are currently some conflicts, but other than that it's good to merge 👍
0883c6a
to
ac121ca
Compare
Thanks for the quick reviews ❤️ |
What?
In passing, I noticed that the Time to Read block can't be inserted in a post more than once.
In this PR I'm removing the restriction. I'm not sure if there's a reason I'm missing for keeping
multiple: false
.Why?
While it's likely the user would only want the block once, I don't think there's any need to impose the restriction.
How?
Remove the line in the block.json
Testing Instructions
Screenshots or screencast