Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing CI docs check #49378

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix failing CI docs check #49378

merged 1 commit into from
Mar 27, 2023

Conversation

Mamaduka
Copy link
Member

What?

Updates docs/manifest.json that causes CI failure on the trunk.

Why?

#49184 was merged with failing CI checks.

Testing Instructions

CI checks should pass.

@Mamaduka Mamaduka requested review from priethor and gziolo March 27, 2023 18:23
@Mamaduka Mamaduka self-assigned this Mar 27, 2023
@Mamaduka Mamaduka added the [Type] Developer Documentation Documentation for developers label Mar 27, 2023
fabiankaegy
fabiankaegy approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Once CI verifies it this can be merged

@github-actions
Copy link

Flaky tests detected in cfb480a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4535288742
📝 Reported issues:

@Mamaduka Mamaduka merged commit 1fab9ed into trunk Mar 27, 2023
@Mamaduka Mamaduka deleted the fix/failing-docs-ci-check branch March 27, 2023 18:55
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 27, 2023
@priethor
Copy link
Contributor

Thanks @Mamaduka; sorry for the trouble! ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@priethor priethor Awaiting requested review from priethor

@gziolo gziolo Awaiting requested review from gziolo

Assignees

@Mamaduka Mamaduka

Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 15.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Mamaduka @priethor @fabiankaegy