Proposal: Block copy filter #49464
Closed
Proposal: Block copy filter #49464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
changed the title
|
Size Change: +11 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
gziolo
added
[Feature] Block API
|
I have this wild idea I wanted to share. Would it fit as a new type of block transforms, e.g. transforms: {
from: [
{
type: 'copy',
transform: ( attributes ) => {
return createBlock( 'my-plugin/block', {
...attributes,
foo: attributes.foo + 1,
} );
},
},
]
},I don't know if it conceptually fully makes sense to put in the bucket of transforms, but maybe we wouldn't need a new filter as folks could use the existing |
gziolo
added
the
[Type] Technical Prototype
|
Actually, I figured out that we could use better syntax by replicating the transforms: {
copy( attributes ) {
return createBlock( 'my-plugin/block', {
...attributes,
foo: attributes.foo + 1,
} );
},
},This way it would be also simple to replace the |
4 tasks
|
Yes, I think |
|
Neat idea. It seems within the spirit of what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why
Adds a new filter that lets extenders customise what happens when the block is duplicated.
The motivation for this is to handle cases such as #29693 where a block wants to track a foreign key of some kind.
It's not implemented in this PR, but it also would let us move away from using
__internalWidgetIdwhich is how the widget editor tracks which widget entity should be updated when a block is modified. It's a hack that works because__internalWidgetIddoes not appear in theblock.jsonand so is filtered out when the block is duplicated. Using acopyfunction like above would make this behaviour more explicit.How to test
View instructions
Paste this into DevTools:
You will then have a Product block that simulates the use case in #29693. Insert the block and notice that a product with ID 1 is created. Duplicate the block and notice that a product with ID 2 is created.