Update media and video icons #49523
Merged
Update media and video icons #49523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
[Block] Media & Text
richtabor
requested review from
a team
and removed request for
ajitbohra and
ellatrix
|
Size Change: +2.14 kB (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
Wouldn't it make sense to use the media icon on the 'Open Media Library' button too? 🤔 I don't think it's necessarily a blocker because it'd be nice to update the old icon regardless, but the new one looks a little busy. Is there a more abstract way to represent images/video/audio? A couple of ideas that might inspire something better:
|
Ha, maybe. I'm not sure why the video icon is representative of the Media Library currently. I like its simplicity though.
Agreed. It's basically a filled-in group block. I'll take a few to jam on that left-most icon; there's potential there.
|
|
Good catch, I also agree the replacement icon should be used for the open media library action as well. |
|
I like the new icon Rich shared here: #49523 (comment) |
|
I updated the media icon as such. Thoughts?
|
|
Hey Rich. That looks really nice! Well done! |
apeatling
approved these changes
Apr 4, 2023
|
Flaky tests detected in a27a264. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4620677715
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Was fixing the core/media-text media-container-icon and noticed that the
mediaandvideoicons are the same icons. Themediaicon is used when referencing the Media Library (storybook), even though its technically a video icon:I have two proposed paths to take:
Update the
mediaicon to accurately reflect images and videos. Then tweak the places where the existingmediaicons are used, to reference the actualvideoicon (what this PR does).Update the
mediaicon to accurately reflect images and videos. Keep the newmediaicon assigned to the Media Library menu items. The downside here is that it's not always the case that images can be replaced by videos (but perhaps it should be). Currently, the Image block does not allow for video file types.Another alternative would be to add a new icon to the library, but I don't feel it's necessary while this media/video icon discrepancy is in play.
Testing Instructions
mediaicon.videoicon).Screenshots or screencast
The custom media-container-icon in the Media & Text block in trunk. It doesn't fit the design language of all the other icons, and shouldn't be its own custom icon in the block anyhow:
The updated
mediaicon, now in use within the Media & Text block placeholder state:The
videoicon, now in use within Media Library menu items. There is no visual change; just referencing the actual video icon.