Demo cmd click for navigation while editing #49582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +171 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 64e3c63. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4656962698
|
|
This is cool! For the sake of conversation, a quick GIF showing me holding ⌘ while clicking a link to a post:
There's obviously a draft PR error in that GIF showing it link to gutenberg.test, whereas I'm using local, so there's some hardcoding going on. But I can glean the behavior, it navigates you to the published URL. I love that, but can we make it navigate to the URL inside the editor instead? I.e. keep you in the editor. This would essentialy be a first power-user verson of "browse mode", and ideally we could make it work for any URL, not just those from links, but from navigation items, or buttons as well. Speaking of keeping you in the editor, the main concept is inspired a bit by VS Code as well, so we might even consider including a tooltip:
The tooltip could get annoying, but it could also make it usable by not just those in the know, so something to test out. What do you think? |
draganescu
force-pushed
the
try/cmd-click-navigation
branch
from
74511cb
to
64e3c63
Compare
|
I fixed the hardcoded host and yes the intent is to remain in the editor if the link you cmd+click is a page or a post. If the link is an external link it would just open in a new tab. But what is annoying to me is that whenever you click in a link that pop over shows up. Is cmd+click a good interaction or should we add a button to that popover instead? |
I would avoid adding buttons to the popover, mainly because I think of this feature as being link agnostic — that is, it should ideally work on any URL in the block editor, whether hyperlinks, buttons, nav items, or even third party stuff. I recognize that might be a super tall order, and we can potentially do or start with less. But essentially I see this as the first steps of actual browse mode, the feature where you can navigate from page to page inside the editor. So it seems great to start super minimalist for now, even without a tooltip if that's challenging. The URL popover can evolve in various ways, to be less incompatible with any tooltips if that's a challenge. If we should do anything to that popover, it could be to have the URL that shows up inside the popover open the link in the editor rather than the frontend. This link:
What do you think? |
|
I will close this and try the idea from @jasmussen to click on the URL of the linkUI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a bad demo of a nice feature: cmd + click to navigate in the editor to linked posts or pages.
cmd-click-post-navigation.mp4