Image block: fix image size control percentage selection #49628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +59 B (0%) Total Size: 1.35 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c327aa8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4626222574
|
…with the callback value and not the state value
apeatling
reviewed
Apr 6, 2023
apeatling
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a small issue in the image block where the percentage sizes were not selected correctly when the user adjusts sizes using the number controls.
How?
The issue is that when using the number controls, the sizes were being stored as a string, while they are usually a number.
The component does this check to see if the current size matches the percentage presets:
It was failing because
string!==number.The best fix seems to be to consistently store values as numbers, so that's what I've done here.
Testing Instructions
In trunk: Observe that 100% doesn't become re-selected
In this branch: 100% should become reselected
Screenshots or screencast
Before
After