[Mobile] - Refactor BlockListItem #49765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
geriux
force-pushed
the
rnmobile/refactor-block-list-item
branch
from
103608a
to
8b5a27a
Compare
|
Flaky tests detected in 869ccb76d6a61e4b50e226c622d3b9e4cbb2f01c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4798861456
|
geriux
added
the
Mobile App - Automation
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
geriux
removed
Mobile App - Automation
geriux
force-pushed
the
rnmobile/use-editor-canvas-margins-hook
branch
from
8d93ea5
to
7b98040
Compare
geriux
force-pushed
the
rnmobile/refactor-block-list-item
branch
from
faf5d51
to
b81414c
Compare
dcalhoun
reviewed
Apr 21, 2023
geriux
force-pushed
the
rnmobile/use-editor-canvas-margins-hook
branch
from
7b98040
to
33d4472
Compare
geriux
force-pushed
the
rnmobile/refactor-block-list-item
branch
from
5d44504
to
869ccb7
Compare
|
This branch has been updated with the feature branch, it also includes an extra commit 869ccb7 that adds two missing props. |
Base automatically changed from
rnmobile/use-editor-canvas-margins-hook
to
rnmobile/block-list-refactor
April 25, 2023 15:50
geriux
force-pushed
the
rnmobile/refactor-block-list-item
branch
from
869ccb7
to
88dc039
Compare
added 5 commits
May 3, 2023 18:20
…uses the new useEditorWrapperStyles and simplifies usage of some props and selectors
… down through restProps
…nt, rootClientId) passed down to the Block component
geriux
force-pushed
the
rnmobile/refactor-block-list-item
branch
from
88dc039
to
f9083d0
Compare
|
Hey @dcalhoun 👋 this PR is now targeting |
dcalhoun
approved these changes
May 4, 2023
| * @param {boolean} props.isStackedHorizontally Whether the block is stacked horizontally. | ||
| * @param {number} props.marginHorizontal The horizontal margin. | ||
| * @param {number} props.marginVertical The vertical margin. | ||
| * @param {Function} props.onAddBlock On Add block callback. |
There was a problem hiding this comment.
Suggestion to match casing of other descriptions.
Suggested change
| * @param {Function} props.onAddBlock On Add block callback. | |
| * @param {Function} props.onAddBlock On add block callback. |
| * @param {boolean} props.isStackedHorizontally Whether the block is stacked horizontally. | ||
| * @param {number} props.marginHorizontal The horizontal margin. | ||
| * @param {number} props.marginVertical The vertical margin. | ||
| * @param {Function} props.onAddBlock On Add block callback. |
There was a problem hiding this comment.
Suggestion to match casing of other descriptions.
Suggested change
| * @param {Function} props.onAddBlock On Add block callback. | |
| * @param {Function} props.onAddBlock On add block callback. |
# Conflicts: # packages/block-editor/src/components/block-list/block-list-item.native.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes wordpress-mobile/gutenberg-mobile#5615
Fixes wordpress-mobile/gutenberg-mobile#4081
Related PRs:
What?
This PR refactors the
BlockListItemcomponent by updating the code into a functional component, using the new useEditorWrapperStyles hook.Why?
To keep the code updated with the latest code practices and to simplify its logic.
How?
BlockListItemContent, andBlockListItemBlockcomponent, this way we know which props are being received and passed down easilyTesting Instructions
CI checks should pass for both Gutenberg and Gutenberg mobile.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A