[RNMobile] Extend non-cached endpoints on Android #50216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the way non-cached endpoints are managed. We now use the 'native.disabled_caching_endpoints' filter to extend the list of endpoints that shouldn't be cached. This change allows us to add more non-cached endpoints dynamically from different parts of the codebase.
SiobhyB
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: +1.57 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobile: Prevent caching ofvideoendpoint on Android wordpress-mobile/gutenberg-mobile#5710What?
This PR introduces a refactoring of how non-cached endpoints are managed in React Native's
api-fetch-setupfile, specifically for Android. A new filter,native.disabled_caching_endpoints, has been introduced that can dynamically extend the list of endpoints that shouldn't be cached.Why?
Previously, the list of non-cached endpoints was hardcoded and not flexible for extension. Given the growing complexity of the apps and the need to disable caching for specific endpoints dynamically, it is valuable to allow the possibility of adding more non-cached endpoints from different parts of the codebase.
How?
801b7ba: A new filter,
native.disabled_caching_endpoints, has been created. This filter is called within theshouldEnableCachingfunction every time a request is made, ensuring that the updated list of non-cachable endpoints is used for deciding whether to enable caching.Testing Instructions
Please refer to wordpress-mobile/gutenberg-mobile#5710 for an example of the new filter being utilised in a different part of the codebase, along with testing steps for that scenario.