Try: Light scrim and softer shadows. #50314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +372 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
It may just be me, but I find the boundaries of the modal much less clear with the white scrim – there's not enough contrast. It wouldn't be so bad if we could apply some Imo we should explore these things separately. With the introduction of the Frame in site view (and its interplay with things like modals, snackbars, popovers) it might be a good time to explore an abstracted elevation scale to replace the current prescriptive one. |
|
Right, we tried that, it had some performance issues. Hey, I tried the black again, but less opaque, what do you think?
|
|
Flaky tests detected in ac0417b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4890519177
|
Not sure the light works well as you mentioned, within the Site View especially, but this variation looks fine. |
|
Closing, as separate work is in progress and this is older. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Work in progress!
Our shadows are not super consistent, and they can in places fel a bit heavy, especially the modal. Popover:
Modal:
This PR aims to bring a little consistency and system to them, and make them lighter, literally, with a white scrim, and softer:
It also adds a depth in between popover and modal, tentatively called "confirm", for the alert/confirm variant of the modal dialog component:
This is a draft PR in part to validate these shadows, but also because the component needs a little work in order to work with the new light scrim. Notably that light scrim does not look good in the dark site view:
Testing Instructions