Revert docker-compose exec to docker-compose run #50412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Build Tooling
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
tests are running: |
|
Found a real fix at #50411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Effectively reverts #50007, because phpunit tests are not running on trunk.
#50411 adds debug around exec calls to see if we can figure out the issue.
Why?
Because phpunit tests are not running on trunk.
How?
Change docker-compose exec back to run
Testing Instructions
Phpunit tests should pass (CHECK OUTPUT TO MAKE SURE TESTS RUN)
Follow-up
Testing Instructions for Keyboard
Screenshots or screencast