[RNMobile] Use host app namespace in reusable block message #50478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 16700f376b2b81427d0741e48260a41aa6fd82e8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4935054336
|
|
Edit: After initially not being able to test this PR correctly due to not having a Reusable tab in my app's Block Inserter, I switched branches to test #50475. On that branch I was able to follow all of that PR's testing steps correctly without any issues (including seeing the Reusable tab on the Block Inserter). I then returned to this branch, and was able to follow all of the testing steps correctly without issues as well. Leaving this info below of my initial experience just in case it helps in the future. Perhaps my initial experience was some sort of caching or watchman issue that resolved itself when switching branches, as I tested both branches using the same site and the same post without any configuration changes to the site or app settings. Original note: The logic of the code looks like it should switch the host app name correctly. 👍 However, I am unable to actually see the correct message in order to actually test. Instead, I see the message 'Reusable Block' is not fully-supported (shown in the screenshot below. Perhaps I am missing a configuration step, as I don't see the Reusable tab in the Block Inserter as indicated on this documentation page. Here are the steps I took:
The "'Reusable Block' is not fully-supported" message comes from the Missing Block screen, and not the block/edit.native.js screen that was updated in this PR, so it seems my site may not be configured to invoke the Reusable tab on the Block Inserter correctly. Do you note any testing or configuration steps I am missing? 🤔
|
derekblank
approved these changes
May 10, 2023
fluiddot
force-pushed
the
rnmobile/fix/reusable-block-message
branch
from
6d934bb
to
16700f3
Compare
fluiddot
force-pushed
the
rnmobile/fix/reusable-block-message
branch
from
16700f3
to
088b66d
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#5722.
What?
Adds the host app namespace in the message displayed when trying to edit a reusable block.
Why?
The Gutenberg Mobile editor can be used on different host apps, hence we need to reference the proper app name in the message.
How?
Add the host app namespace fetched from editor settings into the message string.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A