Global Styles: Add back the global styles logic that forces the solid border when color or width applied. #50498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
6 tasks
youknowriad
commented
May 10, 2023
| settings={ settings } | ||
| /> | ||
| ) } | ||
| { hasEffectsPanel && ( | ||
| <StylesEffectsPanel | ||
| inheritedValue={ inheritedStyleWithLayout } | ||
| value={ styleWithLayout } | ||
| onChange={ onChangeDimensions } | ||
| onChange={ setStyle } |
There was a problem hiding this comment.
This is an unrelated change but it's a small optim/typo fix (same for the next change)
|
Size Change: +198 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for the quick fix @youknowriad 🚀
It looks like we'll need another small tweak to match the current code in the global styles border panel.
Also, can we now remove the global styles border panel entirely?
I'm out of time today but will give this a full test tomorrow and can make any further updates needed then if you'd like.
|
Flaky tests detected in 6c0944bda921fb8ab9f67f759a36d2d2ece9910b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4935178260
|
|
Updated. Indeed, the border panel seems like dead code 👍 |
aaronrobertshaw
approved these changes
May 11, 2023
There was a problem hiding this comment.
LGTM 🚢
✅ Border controls work as expected in both block editor and global styles
✅ Code changes look good including old global styles border panel removal
✅ Border radius is maintained when adjusting other global styles border properties
The failing unit tests look related to the Fonts API that I believe was reverted overnight. I'll rebase the PR and see if we can't get them passing.
Thanks again for the quick work on this.
… border when color or width applied.
aaronrobertshaw
force-pushed
the
fix/border-fallback-global-style
branch
from
6c0944b
to
0f5a1c4
Compare
cbravobernal
added
the
Global Styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced int #49428
See #49428 (comment)
What?
In Global Styles, we have some logic in place that forces the border style to be "solid" when a color/width is applied. This PR just restores that logic that was removed inadvertently.
Testing Instructions
1- Open the "button" global styles panel
2- Type 1px in the "border width" input
3- Verify that the "solid" style is applied on the button