Lodash: Remove from Gallery block #50591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
glendaviesnz,
flootr,
chad1008,
fluiddot,
ntsekouras and
fabiankaegy
|
Size Change: -2 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
This looks fine from the web client side as the V1 code path won't be getting called anymore now anyway as far as I can tell. @dcalhoun from the native side do you think we still need to maintain the v1 Gallery code path? The web code is defaulting to v2 now, but the native code still calls this check to determine which version to run. |
dcalhoun
approved these changes
May 16, 2023
There was a problem hiding this comment.
The changes make sense to me. Thank you!
I tested empty and populated Galleries — both v1 and v2 — on an iPhone 14 Pro simulator. I did not encounter any issues.
@dcalhoun from the native side do you think we still need to maintain the v1 Gallery code path? The web code is defaulting to v2 now, but the native code still calls this check to determine which version to run.
@glendaviesnz my understanding is we still need this check to continue supporting Gallery v1 in the mobile app. @fluiddot given you helped introduce this check, are you able to confirm this? Should we have timeframe for removing Gallery v1 support or retain it indefinitely?
We'd need to check first the adoption metrics of Gallery V2 in the app, but since we introduce it a while ago, most likely we could remove V1 soon. |
|
Thank you all 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash from the Gallery block.
Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're using straightforward native JS functionality instead.
Testing Instructions