Removes the Post Content block from the inserter in the post editor #50620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it can't be used there
glendaviesnz
added
[Type] Enhancement
|
Size Change: +5 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
talldan
approved these changes
May 15, 2023
|
Does this apply to all post types? Let's say a plugin adds an "event" post type to a WordPress Install. A reasonable use case for this plugin would be for a creator to utilize the Query Loop block to list out events in a post or a page. With this change, it appears this is something intentionally no longer supported? I definitely get the rationale for not enabling the relevant "post" content block for the viewed post type but this eliminates a whole class of potential use cases around utilizing content from other post types. |
|
@glendaviesnz to reiterate @nerrad, I think we need to look more closely at this. I 100% agree that the Post Content block should not be insertable in the Post Editor, but it should be insertable within a Query block in the Post Editor. This change potentially prevents a lot of reasonable Query layouts, especially once you involve CPTs.
Noting @jameskoster's comment in the original issue. Not sure how we accomplish this though 🤔 But at the end of the day, I think having the error message is better than also preventing the block in Query block. Edit: Also wanted to note that the error message does not display when the block is placed inside of a Query block (unless to prevent inception), only when placed outside of the block. |
Shouldnt that be possible with the ancestor property when registering the block? Or am I missing something obvious here? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the Post content block from the inserter in the Post Editor
Why?
Fixes: #36870 This block just gives an error message about not being usable in a post, so no point in having it in the inserter there.
How?
Uses the same filter that is being used to stop the template part block being used in the Post editor
Testing Instructions
Screenshots or screencast
Before:
After:
