Hide the hidden navigation block #50662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Bug
|
Size Change: +17 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dea9824. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5322654337
|
|
Unfortunately, using |
|
Either that or we stop using LinkUI in that sidebar :) |
draganescu
force-pushed
the
fix/keyboard-tabbing-into-hidden-block
branch
from
653d6f8
to
dea9824
Compare
|
Now that we don't use LinkControl anymore we could apply this fix, as the hidden block shows a horizontal scrollbar when the user has the top toolbar setting toggled on. |
scruffian
approved these changes
Jun 20, 2023
getdave
reviewed
Jun 20, 2023
| @@ -106,11 +105,11 @@ export default function NavigationMenuContent( { rootClientId } ) { | |||
| showAppender={ false } | |||
| /> | |||
| ) } | |||
| <VisuallyHidden aria-hidden="true"> | |||
| <div className="edit-site-sidebar-navigation-screen-navigation-menus__helper-block-editor"> | |||
There was a problem hiding this comment.
I wonder whether this code should have included a comment to explain why we did this?
I know we have Git history but is this covered by any tests to avoid regressions?
There was a problem hiding this comment.
maybe we should keep the aria-hidden=true too?
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50639
Why?
We use a hidden navigation block to allow the edits to the navigation entity to be caught by the entity system and also to allow the effects of the block to run. This block was hidden using
VisuallyHiddenwhich is the wrong component for this case.Here we want to really hide the block, not hide it visually.
How?
Instead of using
VisuallyHiddenI just use adivthat is set todisplay:none.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
N/A