Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process template part shortcodes before blocks #50801

Merged
merged 3 commits into from
May 20, 2023
Merged

Process template part shortcodes before blocks #50801

merged 3 commits into from
May 20, 2023

Conversation

antpb
Copy link
Contributor

@antpb antpb commented May 20, 2023

Restoring shortcode support in block templates.

antpb added 3 commits May 19, 2023 18:56
@antpb
Process shortcodes before processing blocks so that dynamic blocks, b…
00374e0 
…y default, do not have shortcodes expanded
@antpb
Revert "Process shortcodes before processing blocks so that dynamic b…
a2aaf55 
…locks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.
@antpb
Process shortcodes before processing blocks so that dynamic blocks, b…
ef1b818 
…y default, do not have shortcodes expanded
@antpb antpb requested a review from ajitbohra as a code owner May 20, 2023 00:01
@antpb antpb requested review from youknowriad and mtias and removed request for ajitbohra May 20, 2023 00:05
@github-actions
Copy link

Flaky tests detected in ef1b818.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5029245247
📝 Reported issues:

Clorith
Clorith approved these changes May 20, 2023
View reviewed changes
Copy link
Member

@Clorith Clorith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Shortcodes are processed before blocks in testing 👍

@desrosj desrosj merged commit 3dc64ad into trunk May 20, 2023
@desrosj desrosj deleted the fix/process-template-part-shortcodes-before-blocks branch May 20, 2023 01:07
@github-actions github-actions bot added this to the Gutenberg 15.9 milestone May 20, 2023
desrosj pushed a commit that referenced this pull request May 20, 2023
@antpb @desrosj
Process template part shortcodes before blocks (#50801)
c3c34d0 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
@priethor priethor added Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release [Type] Bug An existing feature does not function as intended labels May 20, 2023
desrosj pushed a commit that referenced this pull request May 20, 2023
@antpb @desrosj
Process template part shortcodes before blocks (#50801)
d6c499c 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
priethor pushed a commit that referenced this pull request May 20, 2023
@antpb @priethor
Process template part shortcodes before blocks (#50801)
7644bfb 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
desrosj pushed a commit that referenced this pull request May 20, 2023
@antpb @desrosj
Process template part shortcodes before blocks (#50801)
0433c1d 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
priethor pushed a commit that referenced this pull request May 20, 2023
@antpb @priethor
Process template part shortcodes before blocks (#50801)
84e1bac 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
@priethor priethor mentioned this pull request May 20, 2023
Merged
priethor added a commit that referenced this pull request May 20, 2023
@priethor
Revert "Process template part shortcodes before blocks (#50801)"
f421ecf 
This reverts commit 7644bfb.
priethor pushed a commit that referenced this pull request May 20, 2023
@antpb @priethor
Process template part shortcodes before blocks (#50801)
62d248c 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
@priethor priethor mentioned this pull request May 20, 2023
Merged
desrosj pushed a commit that referenced this pull request May 20, 2023
@antpb @desrosj
Process template part shortcodes before blocks (#50801)
635d836 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
desrosj pushed a commit that referenced this pull request May 20, 2023
@antpb @desrosj
Process template part shortcodes before blocks (#50801)
e7cf7ca 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
desrosj pushed a commit that referenced this pull request May 20, 2023
@antpb @desrosj
Process template part shortcodes before blocks (#50801)
fed5bb0 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
desrosj pushed a commit that referenced this pull request May 20, 2023
@antpb @desrosj
Process template part shortcodes before blocks (#50801)
2c2ef04 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

* Revert "Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded"

This reverts commit 00374e0.

* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded
priethor added a commit that referenced this pull request May 20, 2023
@priethor @antpb
Process template part shortcodes before blocks (#50801) (#50806)
7dfb3b0 
* Process shortcodes before processing blocks so that dynamic blocks, by default, do not have shortcodes expanded

Co-authored-by: antpb <itartist.pdf@gmail.com>
@priethor priethor removed the Backport to Gutenberg Minor Release Pull request that needs to be backported to a Gutenberg minor release label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priethor priethor priethor approved these changes

@Clorith Clorith Clorith approved these changes

@desrosj desrosj desrosj approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

@mtias mtias Awaiting requested review from mtias

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 15.9
Development

Successfully merging this pull request may close these issues.
4 participants
@antpb @desrosj @Clorith @priethor