Update the document title in the template mode of the post editor #50864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -14.7 kB (-1%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
It's working for me 👍 Would now be a good time to consider adding the Edit: Noticed a styling issue in the site editor – the background has disappeared: 
|
youknowriad
force-pushed
the
update/post-editor-document-title
branch
from
c993694
to
ff0bbca
Compare
|
Fixed the small issues and I added the back button. |
|
The issue in the Site Editor is fixed, thanks. The back button... :)
If you prefer to add this button in a dedicated PR it's probably fine xD |
|
Some e2e tests are failing and it looks like this PR removes the possibility to edit the "template title" from the post editor, are we ok with that? |
I think it's okay. We can probably surface renaming as a suggestion in the command palette (#50407). |
|
Ok this is ready for a final review. It removes two features from the "template mode" of the site editor:
|
|
Quick GIF:
Nice work, looks close! One thing, only templates or template parts should have the purple color for the text. Pages and content should be gray-700. Probably related to the command bar itself, but the "delete template" suggested action feels way too prominent. Probably discussed separately, but it being surfaced here, even focused by default, makes it feel too easy to press ⌘K + Enter and have the template deleted. We can probably be a bit smarter on the mobile breakpoints than just taking up the available space: 
But that's working reasonably well at the moment, so I don't think it should block anything. We can also adjust the designs if need be. |
|
@jasmussen this PR doesn't touch the site editor, it's about the "template mode" in the post editor instead. |
|
Ah, my mistake. Looks good:
A few small things, which are potentially also unrelated to this PR: 
The active state for the button has a black icon. 
It would be a nice polish enhancements to ensure that the button focus for these two go to the edge of the gray box. Potentially remove the inner left/right padding and rely just on the buttons themselves. 
The spacing between chevron and "Back" could be smaller. I wonder if this is a result of the icon button default spacing, in which case we might want to discuss this in a more systematic way. 
Probably the best thing about this PR, we can remove the "Back" button in the canvas! Can we? |
|
Thanks for the review. I've updated the spacing metrics and removed the old "back" button. |
jasmussen
approved these changes
May 30, 2023
There was a problem hiding this comment.
Tentative approval, could use a code sanity check. Nice PR, big improvement.
One thing to still fix, the page icon is still black when you're clicking the command bar. In case it's separate, okay to fix separately, just like applying the purple only to templates and tps.
37 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #50378
What?
This PR updates the design of the "title bar" in the "template mode" of the post editor to match the new design in the site editor.
I considered whether I should be showing the title bar in the "regular mode" of the post editor too with the current post/page but because of the implications on the "top toolbar", I decided to leave this for a separate PR. Let me know what you think here?
Testing Instructions
1- Open the post editor
2- Click on the "template -> edit" from the document sidebar.
3- Notice the new design of the "title bar".