Remove redundant calls to disable the Styles welcome guide #50871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
commented
May 23, 2023
Comment on lines
-11
to
-13
| editor: async ( { page }, use ) => { | ||
| await use( new Editor( { page } ) ); | ||
| }, |
There was a problem hiding this comment.
The editor is available by default; there's no need for a manul setup.
Mamaduka
commented
May 23, 2023
Comment on lines
+25
to
+27
| test.beforeEach( async ( { admin, editor } ) => { | ||
| await admin.visitSiteEditor(); | ||
| await editor.canvas.click( 'body' ); |
There was a problem hiding this comment.
@ramonjd, I wasn't able to run tests locally without this change. However, it's a common pattern, so I don't think there's a need for a separate PR.
There was a problem hiding this comment.
No worries, thanks for the heads up!
Mamaduka
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A minor cleanup after #50852.
Why?
The Styles panel welcome guide is now correctly disabled when visiting the Site Editor, so there's no need for separate helper methods.
Testing Instructions
CI should be green.