Iframe: avoid asset parsing, avoid body replacement, fix script localisation #50913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -200 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/iframe-without-asset-parsing
branch
from
1f2b146
to
02955d6
Compare
ellatrix
added
[Type] Performance
|
Flaky tests detected in 27b1cc4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5476698634
|
ellatrix
force-pushed
the
try/iframe-without-asset-parsing
branch
from
0824f10
to
3b22e53
Compare
ellatrix
force-pushed
the
try/iframe-without-asset-parsing
branch
from
9503913
to
e231369
Compare
ellatrix
force-pushed
the
try/iframe-without-asset-parsing
branch
from
e231369
to
9ce9ae1
Compare
ellatrix
changed the title
|
Fixed by #52405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49655 (comment).
Since we started using
srcDocand now a src with a blob, we can simply pass the style and script dependencies we get as HTML. We don't need to parse the HTML separately and then add it through as React elements.Additionally, we should avoid replacing the body element. Scripts should be loaded on page load as they normally would so they can make use of
loadandDOMContentLoadedevents, with the root elements being available and not replaced later.This should also fix script localisation since the browser now handles script loading.
Why?
Simplify, performance.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast