Lodash: Remove _.isEmpty() from site editor
#50917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
sgomes,
aristath,
jsnajdr,
swissspidy,
ramonjd,
flootr,
chad1008,
ntsekouras and
fabiankaegy
tyxla
commented
May 24, 2023
| @@ -14,7 +9,7 @@ const { Fill: ToolsMoreMenuGroup, Slot } = createSlotFill( | |||
|
|
|||
| ToolsMoreMenuGroup.Slot = ( { fillProps } ) => ( | |||
| <Slot fillProps={ fillProps }> | |||
| { ( fills ) => ! isEmpty( fills ) && fills } | |||
| { ( fills ) => fills && fills.length > 0 } | |||
There was a problem hiding this comment.
fills are always an array:
I can actually remove the fills && check, but decided to keep it just in case.
| @@ -30,6 +25,10 @@ import EditorCanvasContainer from '../editor-canvas-container'; | |||
| const { ExperimentalBlockEditorProvider, useGlobalStylesOutputWithConfig } = | |||
| unlock( blockEditorPrivateApis ); | |||
|
|
|||
| function isObjectEmpty( object ) { | |||
There was a problem hiding this comment.
Used 4 times, so it can't hurt to have it as an inline helper function.
| @@ -42,7 +41,7 @@ function Revisions( { onClose, userConfig, blocks } ) { | |||
| ); | |||
|
|
|||
| const mergedConfig = useMemo( () => { | |||
| if ( ! isEmpty( userConfig ) && ! isEmpty( baseConfig ) ) { | |||
| if ( ! isObjectEmpty( userConfig ) && ! isObjectEmpty( baseConfig ) ) { | |||
There was a problem hiding this comment.
Both userConfig and baseConfig are objects, but we're adding safeguards just in case.
| @@ -65,7 +64,7 @@ function Revisions( { onClose, userConfig, blocks } ) { | |||
| const [ globalStyles ] = useGlobalStylesOutputWithConfig( mergedConfig ); | |||
|
|
|||
| const editorStyles = | |||
| ! isEmpty( globalStyles ) && ! isEmpty( userConfig ) | |||
| ! isObjectEmpty( globalStyles ) && ! isObjectEmpty( userConfig ) | |||
There was a problem hiding this comment.
Both userConfig and globalStyles are objects, but we're adding safeguards just in case.
| if ( | ||
| isDirty && | ||
| userConfig && | ||
| Object.keys( userConfig ).length > 0 && |
There was a problem hiding this comment.
userConfig is already used as a potentially nullish object, which is why we're adding the extra checks.
|
Size Change: +7 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in eaeebf9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5071041040
|
ramonjd
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.isEmpty()from the site editor.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
An object is empty if it's not an object or if it has zero properties. We're using truthiness checks and
Object.keys().lengthto verify that.Testing Instructions