List View: Append when dragging into collapsed blocks #50936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Enhancement
andrewserong
requested review from
noisysocks,
talldan,
jameskoster,
jasmussen,
apeatling,
ramonjd and
tellthemachines
|
Size Change: +12 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 74fa472. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5075327649
|
talldan
approved these changes
May 25, 2023
talldan
approved these changes
May 25, 2023
|
Thanks for reviewing, Dan! I don't think this PR will be particularly controversial, so I'll merge this in now. Happy to do any follow-up if anyone runs into any issues. |
andrewserong
deleted the
update/list-view-append-when-nesting-collapsed-blocks
branch
25 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #49563, fixes #50716
When dragging a block within the list view over a collapsed block, append the dropped block to the end of the container block's inner blocks, instead of prepending to the beginning of the block.
Why?
As raised in #50716, when a group block is collapsed and a user drags a block onto it, it's likely that the expected result is for the block to be appended to the end of that block's children instead of being prepended.
How?
blockIndexto0explicitly as the block's children are expanded, so the user will be visually attempting to place the block at the beginning of that part of the list.blockIndexif it is available. This places the dragged block at the end of the inner blocks of the container block.Testing Instructions
trunkScreenshots or screencast