Refactor Link Control Settings Drawer to avoid unnecessary prop drilling #50963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
Size Change: -38 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 38a1a9e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5080449189
|
I know right!? I can't believe I wrote the original code 🤦 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor of the settings drawer component to avoid prop drilling.
Relates to work in #50890.
Why?
Simplifies the code and makes it easier to reason about without having to "follow" props through nested components.
How?
Utilises
childrenprop to avoid the prop drilling.Testing Instructions
Check the control behaves as per
trunk.Testing Instructions for Keyboard
Screenshots or screencast