Cover: Add aria-label to fixed and repeated image backgrounds #50990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +64 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3d8dcf9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6556761046
|
|
Deprecation:
Fixtures: |
carolinan
added
[a11y] Labelling
[Block] Cover
carolinan
commented
May 29, 2023
aristath
reviewed
Jul 19, 2023
There was a problem hiding this comment.
I did not do a full review, but from a quick look the code seems reasonale. I'm not 100% sure about the usability of this, as alt and aria-label arew different.
cc @afercia for some feedback here 🙏
I feel this is definitely an improvement over what we currently have, but it would be good to have some additional feedback here
priethor
added
[Focus] Accessibility (a11y)
carolinan
removed
the
[Type] Bug
7 tasks
draganescu
reviewed
Sep 29, 2023
| @@ -19,9 +19,6 @@ | |||
| }, | |||
| "alt": { | |||
There was a problem hiding this comment.
I wonder if the name of the attribute is reflective of what it does now :)
There was a problem hiding this comment.
Maybe the name could be "accessibleText". I'm not sure that is clearer.
draganescu
added
the
[Type] Bug
|
Since it corrects invalid markup produced by the block (having an alt attr for a div with role img) I labeled this as a bug fix. The code looks good 👏🏻 the only question is if this is the way to do it, same as Ari mentioned, is the solution in the PR a recommented way to handle this situation or an ad hoc workaround that works? |
I don't disagree but we are only allowed one Type label. |
draganescu
approved these changes
Oct 13, 2023
aristath
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When a cover block has a fixed or repeated background, it uses a div with the attribute
role="img".The goal of this PR is to solve two issues:
role="img"should not be used if the image is presentational (decorative) and has noalttext.role="img"and an alternative text. Becausealt=""is not a valid option for adivwithrole="img",aria-labelis used instead.Closes #49902
Why?
To improve accessibility when the fixed background or repeated backgrounds are used.
How?
In block.json, the alt block attribute used the
imgas the selector and thealtas the attribute, so I had to remove thesefrom the block.json. I was not able to make this work with the
<image, the<div>, thealt, and thearia-labelwithout removing it.Previous:
In the PR:
Testing Instructions
role="img"and does not have anaria-label. Do the same on the front.imgtag and thealtattribute. Do the same on the front.Testing Instructions for Screen readers
Screenshots or screencast