Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "preview" mode/step from Link Control component #50998

Draft
wants to merge 24 commits into
base: trunk
Choose a base branch
from
Draft

Remove "preview" mode/step from Link Control component #50998

wants to merge 24 commits into from
+294 −223

Commits on Jan 10, 2024

  1. Remove edit control from preview

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    c4b166f View commit details
    Browse the repository at this point in the history

  2. Remove image and description from preview

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    5be5c28 View commit details
    Browse the repository at this point in the history

  3. Don’t use label in preview title and this represents an entity

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    fbb69ad View commit details
    Browse the repository at this point in the history

  4. Remove some editing-based conditionals

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3a59112 View commit details
    Browse the repository at this point in the history

  5. Remove remaining state relating to editing mode

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6f39472 View commit details
    Browse the repository at this point in the history

  6. Add border to separate preview from form

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    4b3faf3 View commit details
    Browse the repository at this point in the history

  7. Always focus firstElement in Popover

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f3c1460 View commit details
    Browse the repository at this point in the history

  8. Make Popover a dialog

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    afbed95 View commit details
    Browse the repository at this point in the history

  9. Allow for Popover to be forced closed when exiting the Link UI

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a1a41dc View commit details
    Browse the repository at this point in the history

  10. Reintstate rich media preview for attachments

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    87d8d99 View commit details
    Browse the repository at this point in the history

  11. Fix Nav block to conform to new steps

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    605f11c View commit details
    Browse the repository at this point in the history

  12. Don’t show cancel button if no handler is supplied

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a14c763 View commit details
    Browse the repository at this point in the history

  13. Remove stopEditing internal mode

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6a310ac View commit details
    Browse the repository at this point in the history

  14. Call onChange will original value to mimic Cancel exiting the edit … 

    …state
    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    31cd887 View commit details
    Browse the repository at this point in the history

  15. Update Core implemenation for button

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    7b1f6e0 View commit details
    Browse the repository at this point in the history

  16. Close UI on submitting link in Navigation block

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    251597c View commit details
    Browse the repository at this point in the history

  17. Differentiate focus handling between create and edit

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    19c457c View commit details
    Browse the repository at this point in the history

  18. Revert previous change

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    cce2a69 View commit details
    Browse the repository at this point in the history

  19. Don’t set ID on direct entry results type

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    7214db7 View commit details
    Browse the repository at this point in the history

  20. Conditionally display search input only for direct entry results

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    dbe5b82 View commit details
    Browse the repository at this point in the history

  21. Show non-searchable URL input for direct entry types

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    8c03f78 View commit details
    Browse the repository at this point in the history

  22. Details entity details in preview

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    656bfb1 View commit details
    Browse the repository at this point in the history

  23. Force stop editing link to remove activeFormats

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    95d495b View commit details
    Browse the repository at this point in the history

  24. Close the Link UI on value updates except upon initial creation

    @getdave
    getdave committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    a4a0927 View commit details
    Browse the repository at this point in the history