Try partially synced patterns via a template block #51042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of the Do we need a |
I feel like it might be needed so that the 'placeholder' blocks that come after the content block can be managed, but maybe there will be some way around that. |
|
I've added some basic PHP rendering code that replaces tokens with the placeholder values. For some reason the buttons block isn't rendering though after I made this change, so I'm debugging that right now. edit: buttons is actually fine, I didn't realise that it only renders when it has text content! |
|
Nice work on taking this idea to a working prototype! |
talldan
force-pushed
the
try/template-block
branch
from
7910f86
to
e277710
Compare
|
Size Change: +966 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e277710. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5196555172
|
talldan
force-pushed
the
try/template-block
branch
from
d2b880c
to
ad92493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A possible first step towards developing the templating concept described in #50456 (comment).
Introduces three new blocks:
At the moment there isn't much functionality. You can select a child block of the template content and click a 'Convert to placeholder' button, which swaps the content with a token, which represents what a user might do when designing a pattern. You can also remove a token, which puts the placeholder back in place.
The block renders dynamically via PHP and swaps the tokens for the placeholder values.
Next steps:
Testing Instructions
Screenshots or screencast