[RNMobile] Fix Android-only issue related to block toolbar not being displayed on some blocks in UBE #51131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We experienced on Android that the `editor` variable might be already defined in some cases when loading UBE's behavior overrides.
fluiddot
added
[Type] Bug
fluiddot
changed the title
fluiddot
changed the title
fluiddot
changed the title
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
|
Flaky tests detected in dbe19a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5132564200
|
geriux
approved these changes
May 31, 2023
geriux
pushed a commit
that referenced
this pull request
May 31, 2023
…displayed on some blocks in UBE (#51131) * Query editor element only in the function is needed We experienced on Android that the `editor` variable might be already defined in some cases when loading UBE's behavior overrides. * Update `react-native-editor` changelog
4 tasks
geriux
pushed a commit
that referenced
this pull request
Jun 2, 2023
* Release script: Update react-native-editor version to 1.96.0 * Release script: Update with changes from 'npm run core preios' * Update CHANGELOG for 1.96.0 * Release script: Update react-native-editor version to 1.96.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix Android-only issue related to block toolbar not being displayed on some blocks in UBE (#51131) * Query editor element only in the function is needed We experienced on Android that the `editor` variable might be already defined in some cases when loading UBE's behavior overrides. * Update `react-native-editor` changelog * Update Changelog * Update Podfile.lock --------- Co-authored-by: Derek Blank <derekpblank@gmail.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
artemiomorales
pushed a commit
to artemiomorales/gutenberg
that referenced
this pull request
Jun 2, 2023
* Release script: Update react-native-editor version to 1.96.0 * Release script: Update with changes from 'npm run core preios' * Update CHANGELOG for 1.96.0 * Release script: Update react-native-editor version to 1.96.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix Android-only issue related to block toolbar not being displayed on some blocks in UBE (WordPress#51131) * Query editor element only in the function is needed We experienced on Android that the `editor` variable might be already defined in some cases when loading UBE's behavior overrides. * Update `react-native-editor` changelog * Update Changelog * Update Podfile.lock --------- Co-authored-by: Derek Blank <derekpblank@gmail.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…displayed on some blocks in UBE (WordPress#51131) * Query editor element only in the function is needed We experienced on Android that the `editor` variable might be already defined in some cases when loading UBE's behavior overrides. * Update `react-native-editor` changelog
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Release script: Update react-native-editor version to 1.96.0 * Release script: Update with changes from 'npm run core preios' * Update CHANGELOG for 1.96.0 * Release script: Update react-native-editor version to 1.96.1 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Fix Android-only issue related to block toolbar not being displayed on some blocks in UBE (WordPress#51131) * Query editor element only in the function is needed We experienced on Android that the `editor` variable might be already defined in some cases when loading UBE's behavior overrides. * Update `react-native-editor` changelog * Update Changelog * Update Podfile.lock --------- Co-authored-by: Derek Blank <derekpblank@gmail.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We identified that on the native unsupported blocks Archive, Calendar, Rating, Slideshow, when editing them via UBE (Unsupported Block Editor), the toolbar is not displayed when selecting the block. This issue can only be reproduced in the Android app.
Why?
Not being able to use the block toolbar for some blocks impacts negatively the experience when using UBE.
How?
The cause of the issue was that the
editorvariable could be already defined in some cases:gutenberg/packages/react-native-bridge/common/gutenberg-web-single-block/editor-behavior-overrides.js
Line 80 in a450434
To solve this, we now query the editor element within the function where is needed, which is called when selecting/unselecting the block.
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast