Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Upgrade React Native 0.71.11 #51303

Merged
merged 70 commits into from
Jul 27, 2023

Commits on Jun 5, 2023

  1. Configuration menu
    Copy the full SHA
    c70eb5b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13ad608 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83b7a16 View commit details
    Browse the repository at this point in the history
  4. Upgrade cocoapods gem

    fluiddot committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    256be9c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    213073d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    cbdb7ff View commit details
    Browse the repository at this point in the history
  2. Mock Linking.addEventListener function

    `Linking.removeEventListener` has been removed in RN `0.71`. The library is mocked by default but doesn't return the `remove` function when calling `addEventListener`.
    fluiddot committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    bd0750b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6cac580 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    311ed3f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5b48573 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ba8496a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ca395c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    2c0e048 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    809b82d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f73574 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Upgrade react-native dependency to version 0.71.11

    It also upgrades `metro-react-native-babel` dependencies following the upgrade helper.
    fluiddot committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    e0cab59 View commit details
    Browse the repository at this point in the history
  2. Mock return value of Linking addEventListener

    We only need to mock the return the value, hence we don't need to mock the entire library.
    fluiddot committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    97265c7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f2edf4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9d4165 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. test: Fix act warning by awaiting LinkPicker loading indicator removal

    The loading indicator is displayed and subsequently removed once the
    suggestion fetches resolve. Explicitly awaiting this element's removal
    fixes the `act` warnings.
    dcalhoun committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    70dbcc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Configuration menu
    Copy the full SHA
    36ccef4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29457bb View commit details
    Browse the repository at this point in the history
  3. build: Upgrade react-native-svg to 13.9.0

    Based on the release notes breaking changes, we should look out for odd
    sizing or display of icons, particularly on Android.
    dcalhoun committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    88b679b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53ea3f9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6d30809 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5be8a68 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Merge branch 'trunk' of github.com:WordPress/gutenberg into rnmobile/…

    …upgrade/react-native-0.71.8
    dcalhoun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    ac7d100 View commit details
    Browse the repository at this point in the history
  2. test: Update link modal snapshot

    This change is a result of applying new props from the RN upgrade to a
    newly introduced snapshot in trunk: 71d2dc5
    dcalhoun committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8bbaf2c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Configuration menu
    Copy the full SHA
    b5c02fd View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Upgrade react-native-linear-gradient to version 2.7.3

    This commit also updates the `react-native-hsv-color-picker` library to point to the same version of `react-native-linear-gradient`.
    fluiddot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    556b3ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb14804 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8

    # Conflicts:
    #	package-lock.json
    fluiddot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    70a78c5 View commit details
    Browse the repository at this point in the history
  4. Update link modal snapshot

    fluiddot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7988b0e View commit details
    Browse the repository at this point in the history
  5. Update package-lock.json file

    The integrity checksum of `react-native-hsv-color-picker` changed because the package has been modified (ref: wordpress-mobile/react-native-hsv-color-picker#10 (comment))
    fluiddot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a756c3e View commit details
    Browse the repository at this point in the history
  6. Disable react-native-screens in navigators

    `react-native-screens` is meant to be used at root level to save memory when having inactive screens. This is not the case of the editor, as the stack navigators are used within the Bottom sheet component.
    As a side note, enabling `react-native-screens` here leads to the editor crashing.
    fluiddot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    e5838f4 View commit details
    Browse the repository at this point in the history
  7. Fix render order of animated view to highlight selected segment

    Rendering the animated view before the segments will ensure that is rendered behind them.
    fluiddot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    f879e29 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    86d36e0 View commit details
    Browse the repository at this point in the history
  9. Revert "Update link modal snapshot"

    This reverts commit 7988b0e.
    
    This is needed after disabling `react-native-screens` in navigators (ref: e5838f4).
    fluiddot committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    8f36b9a View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. [RNMobile] Upgrade React Native 0.71.11 - iOS changes (#51386)

    * refactor: Extract bundle version number to var
    
    * refactor: Delete /.ruby-version, no longer needed
    
    * refactor: Update /podfile to align w/RN updates
    
    * refactor: Remove path names as part of RN upgrade
    
    * Update `Podfile` with changes from RN upgrade helper
    
    * Fix React Native path for `react_native_post_install` script
    
    * Update Pods
    
    * Add patch to fix Reanimated podspec
    
    Without this patch, Reanimated tries to use Hermes version of React Native and produced a build failure. Seems there's an issue in the `podspec` file, as the JSC module is not being added.
    Reference: software-mansion/react-native-reanimated#4254
    
    * Update pods to reflect 0.71.11 target
    
    * Apply changes to pods following `pod install`
    
    * Update `Podfile.lock` file
    
    ---------
    
    Co-authored-by: Siobhan <siobhan@automattic.com>
    fluiddot and Siobhan authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    305db7f View commit details
    Browse the repository at this point in the history
  2. [RNMobile] Upgrade React Native 0.71.11 - Android changes (#51289)

    * Upgrade Gradle to version 7.5.1
    
    * Upgrade Gradle plugin
    
    * Remove no longer needed files in new version
    
    * Update Flipper initialization
    
    * Update demo project main application
    
    * Remove gradle download task plugin
    
    * Bump ndk version
    
    * Remove no longer need logic related to `newArchEnabled`
    
    * Apply plugin React Native Gradle plugin
    
    * Use React Native and Hermes modules from Maven
    
    We no longer need to publish these binaries because React Native team is publishing React Native binaries to Maven.
    
    * Remove exclude group from Flipper
    
    * Update comments in `build.gradle` to align with new RN version
    
    * Remove deprecated Gradle property
    
    * Add `mavenLocal` repository to allow testing local binaries
    
    * Bump Reanimated and Gesture handler libraries
    
    * Revert "Upgrade Gradle plugin"
    
    This reverts commit 82764a2.
    
    * build: Resolve react-native-gradle-plugin incompatability
    
    Due to host app requirements, we must use AGP 7.2.1. The included patch
    disables logic requiring AGP 7.3. The logic appears to not be required
    for our use cases in the Demo editor or host apps.
    
    We should remove this patch once we upgrade past AGP 7.3.
    
    * Reduce priority of `mavenLocal` repository in Android build configurations
    
    Maven local is used to provide dependencies located locally, which is mainly used for testing and debugging. Hence, published dependencies should be prioritized over local ones.
    
    * Disable `react-native-screens` in navigators
    
    `react-native-screens` is meant to be used at root level to save memory when having inactive screens. This is not the case of the editor, as the stack navigators are used within the Bottom sheet component.
    As a side note, enabling `react-native-screens` here leads to the editor crashing.
    
    * Fix render order of animated view to highlight selected segment
    
    Rendering the animated view before the segments will ensure that is rendered behind them.
    
    * Bump Linear gradient Android library
    
    This library is now published via the `react-native-libraries-publisher` repository.
    
    ---------
    
    Co-authored-by: David Calhoun <github@davidcalhoun.me>
    fluiddot and dcalhoun authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    39570ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad188ac View commit details
    Browse the repository at this point in the history
  4. Update a11y id queries for Android E2E tests

    Starting in React Native 0.71, the accessibility hint is no longer appended to the accessibility content description. Reference: facebook/react-native@0b70b38
    fluiddot committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    9b8d7be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    de27968 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Configuration menu
    Copy the full SHA
    b6f5fba View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Configuration menu
    Copy the full SHA
    bb3afd8 View commit details
    Browse the repository at this point in the history
  2. Update block drop position using Reanimated's shared value

    Seems there's some kind of incompatibility on calling a JS function from a worklet invoked from a gesture handler. For this reason, the logic to set the dropping insertion point has been updated. It now uses a Reanimated's shared value to keep the dragging over position and  `useDerivedValue` hook to listen for changes.
    fluiddot committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    bdd4704 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8

    # Conflicts:
    #	packages/react-native-editor/ios/Podfile.lock
    fluiddot committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    2b3fa44 View commit details
    Browse the repository at this point in the history
  4. Remove unneeded hidden param in Paragraph block test case

    Co-authored-by: David Calhoun <github@davidcalhoun.me>
    fluiddot and dcalhoun authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    643860d View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Configuration menu
    Copy the full SHA
    cf67f49 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a5036dd View commit details
    Browse the repository at this point in the history
  3. Use waitForElementToBeRemoved in Paragraph block test cases

    This way we can avoid waiting for any microtasks of link suggestions.
    fluiddot committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    70c6dcb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2d0a219 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. fix: Cover focal point drag handle visibility

    The lack of an explicit width or height resulted in a invisible drag
    handle. The logic passing the dimensions to the SVG expected a single
    style object. The reality is that it (1) referenced only the Sass styles
    and (2) the combined reference was actually an array of style objects.
    
    Updating the reference and flattening it ensures the appropriate width
    and height are passed to the SVG.
    
    It appears the absence of explicit dimensions was not an issue in
    earlier versions of React Native, but it makes sense why it might be
    required.
    dcalhoun committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    470af37 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. [RNMobile] Use Reanimated in bottom sheet height animation (#52563)

    * Expose max height properties in `BottomSheetProvider`
    
    * Animate bottom sheet's height with Reanimated
    
    Pass `currentHeight` in bottom sheet navigation context
    
    * Use pixel value when setting fullscreen height
    
    We need to pass pixel values in order to animate the height with Reanimated.
    
    * Rename `heightRef` to `maxHeight`
    
    * Re-enable `exhaustive-deps` lint rule in `BottomSheetNavigationContainer`
    
    * Avoid setting height using debounce
    
    * Add test ID to navigation container component
    
    * Mock Reanimated's `now` function
    
    * Update test cases related to bottom sheet height animation
    
    * Update test snapshots
    fluiddot authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0411df1 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8

    # Conflicts:
    #	package-lock.json
    #	packages/react-native-editor/__device-tests__/pages/editor-page.js
    #	packages/react-native-editor/android/app/build.gradle
    #	packages/react-native-editor/ios/Podfile.lock
    fluiddot committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    4482b9d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f34e0c View commit details
    Browse the repository at this point in the history
  3. Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8

    # Conflicts:
    #	packages/block-library/src/audio/test/__snapshots__/edit.native.js.snap
    #	packages/block-library/src/file/test/__snapshots__/edit.native.js.snap
    fluiddot committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    20aaaf3 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    2fad54c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    44b988a View commit details
    Browse the repository at this point in the history
  2. Drop unsupported --no-jetifier from Android cmd

    The `--no-jetifier` option no longer appears to be supported and results in an error when attempting to build the Android demo app.
    
    Ref: wordpress-mobile/gutenberg-mobile#5881 (comment)
    Siobhan committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0c79d79 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fff11e9 View commit details
    Browse the repository at this point in the history
  4. Revert accidental change to .ruby-version

    Siobhan committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    8e496ba View commit details
    Browse the repository at this point in the history
  5. Restore correct dependencies to package-lock.json

    Siobhan committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7b423cd View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    7289045 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ef9edd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    05e9748 View commit details
    Browse the repository at this point in the history
  4. Update package-lock.json file to revert previous conflict resolutions

    In 4482b9d we had a conflict in `package-lock.json` that was solved using the changes from this branch. However, seems that something went wrong and that although the editor has no issues, some e2e tests are failing due to this.
    
    This has been solved by using the latest version of `package-lock.json` file from `trunk` and updating it with the package updates required in the React Native upgrade.
    fluiddot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c6b1311 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    29c2bed View commit details
    Browse the repository at this point in the history
  6. Update Podfile.lock file

    fluiddot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    61669c8 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'trunk' of github.com:WordPress/gutenberg into rnmobile/…

    …upgrade/react-native-0.71.8
    dcalhoun committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5040e6a View commit details
    Browse the repository at this point in the history