-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Upgrade React Native 0.71.11
#51303
Commits on Jun 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c70eb5b - Browse repository at this point
Copy the full SHA c70eb5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13ad608 - Browse repository at this point
Copy the full SHA 13ad608View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83b7a16 - Browse repository at this point
Copy the full SHA 83b7a16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 256be9c - Browse repository at this point
Copy the full SHA 256be9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 213073d - Browse repository at this point
Copy the full SHA 213073dView commit details
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cbdb7ff - Browse repository at this point
Copy the full SHA cbdb7ffView commit details -
Mock
Linking.addEventListener
function`Linking.removeEventListener` has been removed in RN `0.71`. The library is mocked by default but doesn't return the `remove` function when calling `addEventListener`.
Configuration menu - View commit details
-
Copy full SHA for bd0750b - Browse repository at this point
Copy the full SHA bd0750bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cac580 - Browse repository at this point
Copy the full SHA 6cac580View commit details -
Configuration menu - View commit details
-
Copy full SHA for 311ed3f - Browse repository at this point
Copy the full SHA 311ed3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b48573 - Browse repository at this point
Copy the full SHA 5b48573View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba8496a - Browse repository at this point
Copy the full SHA ba8496aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca395c2 - Browse repository at this point
Copy the full SHA ca395c2View commit details
Commits on Jun 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2c0e048 - Browse repository at this point
Copy the full SHA 2c0e048View commit details -
Configuration menu - View commit details
-
Copy full SHA for 809b82d - Browse repository at this point
Copy the full SHA 809b82dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f73574 - Browse repository at this point
Copy the full SHA 3f73574View commit details
Commits on Jun 16, 2023
-
Upgrade
react-native
dependency to version0.71.11
It also upgrades `metro-react-native-babel` dependencies following the upgrade helper.
Configuration menu - View commit details
-
Copy full SHA for e0cab59 - Browse repository at this point
Copy the full SHA e0cab59View commit details -
Mock return value of Linking
addEventListener
We only need to mock the return the value, hence we don't need to mock the entire library.
Configuration menu - View commit details
-
Copy full SHA for 97265c7 - Browse repository at this point
Copy the full SHA 97265c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f2edf4 - Browse repository at this point
Copy the full SHA 9f2edf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9d4165 - Browse repository at this point
Copy the full SHA a9d4165View commit details
Commits on Jun 17, 2023
-
test: Fix act warning by awaiting LinkPicker loading indicator removal
The loading indicator is displayed and subsequently removed once the suggestion fetches resolve. Explicitly awaiting this element's removal fixes the `act` warnings.
Configuration menu - View commit details
-
Copy full SHA for 70dbcc6 - Browse repository at this point
Copy the full SHA 70dbcc6View commit details
Commits on Jun 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 36ccef4 - Browse repository at this point
Copy the full SHA 36ccef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29457bb - Browse repository at this point
Copy the full SHA 29457bbView commit details -
build: Upgrade react-native-svg to 13.9.0
Based on the release notes breaking changes, we should look out for odd sizing or display of icons, particularly on Android.
Configuration menu - View commit details
-
Copy full SHA for 88b679b - Browse repository at this point
Copy the full SHA 88b679bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53ea3f9 - Browse repository at this point
Copy the full SHA 53ea3f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d30809 - Browse repository at this point
Copy the full SHA 6d30809View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5be8a68 - Browse repository at this point
Copy the full SHA 5be8a68View commit details
Commits on Jun 26, 2023
-
Merge branch 'trunk' of github.com:WordPress/gutenberg into rnmobile/…
…upgrade/react-native-0.71.8
Configuration menu - View commit details
-
Copy full SHA for ac7d100 - Browse repository at this point
Copy the full SHA ac7d100View commit details -
test: Update link modal snapshot
This change is a result of applying new props from the RN upgrade to a newly introduced snapshot in trunk: 71d2dc5
Configuration menu - View commit details
-
Copy full SHA for 8bbaf2c - Browse repository at this point
Copy the full SHA 8bbaf2cView commit details
Commits on Jun 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b5c02fd - Browse repository at this point
Copy the full SHA b5c02fdView commit details
Commits on Jun 28, 2023
-
Upgrade
react-native-linear-gradient
to version2.7.3
This commit also updates the `react-native-hsv-color-picker` library to point to the same version of `react-native-linear-gradient`.
Configuration menu - View commit details
-
Copy full SHA for 556b3ef - Browse repository at this point
Copy the full SHA 556b3efView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb14804 - Browse repository at this point
Copy the full SHA fb14804View commit details -
Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8
# Conflicts: # package-lock.json
Configuration menu - View commit details
-
Copy full SHA for 70a78c5 - Browse repository at this point
Copy the full SHA 70a78c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7988b0e - Browse repository at this point
Copy the full SHA 7988b0eView commit details -
The integrity checksum of `react-native-hsv-color-picker` changed because the package has been modified (ref: wordpress-mobile/react-native-hsv-color-picker#10 (comment))
Configuration menu - View commit details
-
Copy full SHA for a756c3e - Browse repository at this point
Copy the full SHA a756c3eView commit details -
Disable
react-native-screens
in navigators`react-native-screens` is meant to be used at root level to save memory when having inactive screens. This is not the case of the editor, as the stack navigators are used within the Bottom sheet component. As a side note, enabling `react-native-screens` here leads to the editor crashing.
Configuration menu - View commit details
-
Copy full SHA for e5838f4 - Browse repository at this point
Copy the full SHA e5838f4View commit details -
Fix render order of animated view to highlight selected segment
Rendering the animated view before the segments will ensure that is rendered behind them.
Configuration menu - View commit details
-
Copy full SHA for f879e29 - Browse repository at this point
Copy the full SHA f879e29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86d36e0 - Browse repository at this point
Copy the full SHA 86d36e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f36b9a - Browse repository at this point
Copy the full SHA 8f36b9aView commit details
Commits on Jun 30, 2023
-
[RNMobile] Upgrade React Native
0.71.11
- iOS changes (#51386)* refactor: Extract bundle version number to var * refactor: Delete /.ruby-version, no longer needed * refactor: Update /podfile to align w/RN updates * refactor: Remove path names as part of RN upgrade * Update `Podfile` with changes from RN upgrade helper * Fix React Native path for `react_native_post_install` script * Update Pods * Add patch to fix Reanimated podspec Without this patch, Reanimated tries to use Hermes version of React Native and produced a build failure. Seems there's an issue in the `podspec` file, as the JSC module is not being added. Reference: software-mansion/react-native-reanimated#4254 * Update pods to reflect 0.71.11 target * Apply changes to pods following `pod install` * Update `Podfile.lock` file --------- Co-authored-by: Siobhan <siobhan@automattic.com>
Configuration menu - View commit details
-
Copy full SHA for 305db7f - Browse repository at this point
Copy the full SHA 305db7fView commit details -
[RNMobile] Upgrade React Native
0.71.11
- Android changes (#51289)* Upgrade Gradle to version 7.5.1 * Upgrade Gradle plugin * Remove no longer needed files in new version * Update Flipper initialization * Update demo project main application * Remove gradle download task plugin * Bump ndk version * Remove no longer need logic related to `newArchEnabled` * Apply plugin React Native Gradle plugin * Use React Native and Hermes modules from Maven We no longer need to publish these binaries because React Native team is publishing React Native binaries to Maven. * Remove exclude group from Flipper * Update comments in `build.gradle` to align with new RN version * Remove deprecated Gradle property * Add `mavenLocal` repository to allow testing local binaries * Bump Reanimated and Gesture handler libraries * Revert "Upgrade Gradle plugin" This reverts commit 82764a2. * build: Resolve react-native-gradle-plugin incompatability Due to host app requirements, we must use AGP 7.2.1. The included patch disables logic requiring AGP 7.3. The logic appears to not be required for our use cases in the Demo editor or host apps. We should remove this patch once we upgrade past AGP 7.3. * Reduce priority of `mavenLocal` repository in Android build configurations Maven local is used to provide dependencies located locally, which is mainly used for testing and debugging. Hence, published dependencies should be prioritized over local ones. * Disable `react-native-screens` in navigators `react-native-screens` is meant to be used at root level to save memory when having inactive screens. This is not the case of the editor, as the stack navigators are used within the Bottom sheet component. As a side note, enabling `react-native-screens` here leads to the editor crashing. * Fix render order of animated view to highlight selected segment Rendering the animated view before the segments will ensure that is rendered behind them. * Bump Linear gradient Android library This library is now published via the `react-native-libraries-publisher` repository. --------- Co-authored-by: David Calhoun <github@davidcalhoun.me>
Configuration menu - View commit details
-
Copy full SHA for 39570ce - Browse repository at this point
Copy the full SHA 39570ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad188ac - Browse repository at this point
Copy the full SHA ad188acView commit details -
Update a11y id queries for Android E2E tests
Starting in React Native 0.71, the accessibility hint is no longer appended to the accessibility content description. Reference: facebook/react-native@0b70b38
Configuration menu - View commit details
-
Copy full SHA for 9b8d7be - Browse repository at this point
Copy the full SHA 9b8d7beView commit details -
Configuration menu - View commit details
-
Copy full SHA for de27968 - Browse repository at this point
Copy the full SHA de27968View commit details
Commits on Jul 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b6f5fba - Browse repository at this point
Copy the full SHA b6f5fbaView commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bb3afd8 - Browse repository at this point
Copy the full SHA bb3afd8View commit details -
Update block drop position using Reanimated's shared value
Seems there's some kind of incompatibility on calling a JS function from a worklet invoked from a gesture handler. For this reason, the logic to set the dropping insertion point has been updated. It now uses a Reanimated's shared value to keep the dragging over position and `useDerivedValue` hook to listen for changes.
Configuration menu - View commit details
-
Copy full SHA for bdd4704 - Browse repository at this point
Copy the full SHA bdd4704View commit details -
Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8
# Conflicts: # packages/react-native-editor/ios/Podfile.lock
Configuration menu - View commit details
-
Copy full SHA for 2b3fa44 - Browse repository at this point
Copy the full SHA 2b3fa44View commit details -
Remove unneeded
hidden
param in Paragraph block test caseCo-authored-by: David Calhoun <github@davidcalhoun.me>
Configuration menu - View commit details
-
Copy full SHA for 643860d - Browse repository at this point
Copy the full SHA 643860dView commit details
Commits on Jul 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cf67f49 - Browse repository at this point
Copy the full SHA cf67f49View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5036dd - Browse repository at this point
Copy the full SHA a5036ddView commit details -
Use
waitForElementToBeRemoved
in Paragraph block test casesThis way we can avoid waiting for any microtasks of link suggestions.
Configuration menu - View commit details
-
Copy full SHA for 70c6dcb - Browse repository at this point
Copy the full SHA 70c6dcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d0a219 - Browse repository at this point
Copy the full SHA 2d0a219View commit details
Commits on Jul 6, 2023
-
fix: Cover focal point drag handle visibility
The lack of an explicit width or height resulted in a invisible drag handle. The logic passing the dimensions to the SVG expected a single style object. The reality is that it (1) referenced only the Sass styles and (2) the combined reference was actually an array of style objects. Updating the reference and flattening it ensures the appropriate width and height are passed to the SVG. It appears the absence of explicit dimensions was not an issue in earlier versions of React Native, but it makes sense why it might be required.
Configuration menu - View commit details
-
Copy full SHA for 470af37 - Browse repository at this point
Copy the full SHA 470af37View commit details
Commits on Jul 14, 2023
-
[RNMobile] Use Reanimated in bottom sheet height animation (#52563)
* Expose max height properties in `BottomSheetProvider` * Animate bottom sheet's height with Reanimated Pass `currentHeight` in bottom sheet navigation context * Use pixel value when setting fullscreen height We need to pass pixel values in order to animate the height with Reanimated. * Rename `heightRef` to `maxHeight` * Re-enable `exhaustive-deps` lint rule in `BottomSheetNavigationContainer` * Avoid setting height using debounce * Add test ID to navigation container component * Mock Reanimated's `now` function * Update test cases related to bottom sheet height animation * Update test snapshots
Configuration menu - View commit details
-
Copy full SHA for 0411df1 - Browse repository at this point
Copy the full SHA 0411df1View commit details
Commits on Jul 19, 2023
-
Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8
# Conflicts: # package-lock.json # packages/react-native-editor/__device-tests__/pages/editor-page.js # packages/react-native-editor/android/app/build.gradle # packages/react-native-editor/ios/Podfile.lock
Configuration menu - View commit details
-
Copy full SHA for 4482b9d - Browse repository at this point
Copy the full SHA 4482b9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f34e0c - Browse repository at this point
Copy the full SHA 1f34e0cView commit details -
Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8
# Conflicts: # packages/block-library/src/audio/test/__snapshots__/edit.native.js.snap # packages/block-library/src/file/test/__snapshots__/edit.native.js.snap
Configuration menu - View commit details
-
Copy full SHA for 20aaaf3 - Browse repository at this point
Copy the full SHA 20aaaf3View commit details
Commits on Jul 20, 2023
-
Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8
Siobhan committedJul 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 2fad54c - Browse repository at this point
Copy the full SHA 2fad54cView commit details
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 44b988a - Browse repository at this point
Copy the full SHA 44b988aView commit details -
Drop unsupported
--no-jetifier
from Android cmdThe `--no-jetifier` option no longer appears to be supported and results in an error when attempting to build the Android demo app. Ref: wordpress-mobile/gutenberg-mobile#5881 (comment)
Siobhan committedJul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 0c79d79 - Browse repository at this point
Copy the full SHA 0c79d79View commit details -
Merge branch 'trunk' into rnmobile/upgrade/react-native-0.71.8
Siobhan committedJul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for fff11e9 - Browse repository at this point
Copy the full SHA fff11e9View commit details -
Revert accidental change to .ruby-version
Siobhan committedJul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 8e496ba - Browse repository at this point
Copy the full SHA 8e496baView commit details -
Restore correct dependencies to package-lock.json
Siobhan committedJul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 7b423cd - Browse repository at this point
Copy the full SHA 7b423cdView commit details
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7289045 - Browse repository at this point
Copy the full SHA 7289045View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ef9edd - Browse repository at this point
Copy the full SHA 3ef9eddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05e9748 - Browse repository at this point
Copy the full SHA 05e9748View commit details -
Update
package-lock.json
file to revert previous conflict resolutionsIn 4482b9d we had a conflict in `package-lock.json` that was solved using the changes from this branch. However, seems that something went wrong and that although the editor has no issues, some e2e tests are failing due to this. This has been solved by using the latest version of `package-lock.json` file from `trunk` and updating it with the package updates required in the React Native upgrade.
Configuration menu - View commit details
-
Copy full SHA for c6b1311 - Browse repository at this point
Copy the full SHA c6b1311View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c2bed - Browse repository at this point
Copy the full SHA 29c2bedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61669c8 - Browse repository at this point
Copy the full SHA 61669c8View commit details -
Merge branch 'trunk' of github.com:WordPress/gutenberg into rnmobile/…
…upgrade/react-native-0.71.8
Configuration menu - View commit details
-
Copy full SHA for 5040e6a - Browse repository at this point
Copy the full SHA 5040e6aView commit details