Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Display custom color value in mobile Cover Block color picker #51414

Merged
merged 13 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion packages/block-library/src/cover/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
TouchableWithoutFeedback,
InteractionManager,
AccessibilityInfo,
Text,
Platform,
} from 'react-native';
import Video from 'react-native-video';
Expand Down Expand Up @@ -364,6 +365,19 @@ const Cover = ( {
} );
}, [] );

const selectedColorText = getStylesFromColorScheme(
styles.selectedColorText,
styles.selectedColorTextDark
);

const bottomLabelText = customOverlayColor ? (
<Text style={ selectedColorText }>
{ customOverlayColor.toUpperCase() }
</Text>
) : (
__( 'Select a color' )
);

const colorPickerControls = (
<InspectorControls>
<BottomSheetConsumer>
Expand Down Expand Up @@ -393,7 +407,7 @@ const Cover = ( {
isBottomSheetContentScrolling={
isBottomSheetContentScrolling
}
bottomLabelText={ __( 'Select a color' ) }
bottomLabelText={ bottomLabelText }
/>
) }
</BottomSheetConsumer>
Expand Down
11 changes: 11 additions & 0 deletions packages/block-library/src/cover/style.native.scss
Original file line number Diff line number Diff line change
Expand Up @@ -207,3 +207,14 @@
.mediaPlaceholderEmptyStateContainer {
height: 300;
}

.selectedColorText {
font-family: $default-monospace-font;
color: $light-primary;
font-size: 16px;
font-weight: 400;
}

.selectedColorTextDark {
color: $dark-primary;
}
36 changes: 35 additions & 1 deletion packages/block-library/src/cover/test/edit.native.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import { Image } from 'react-native';
import { Image, Pressable } from 'react-native';
import {
getEditorHtml,
initializeEditor,
Expand All @@ -12,6 +12,7 @@ import {
getBlock,
openBlockSettings,
} from 'test/helpers';
import HsvColorPicker from 'react-native-hsv-color-picker';

/**
* WordPress dependencies
Expand Down Expand Up @@ -530,6 +531,39 @@ describe( 'color settings', () => {

expect( getEditorHtml() ).toMatchSnapshot();
} );

it( 'displays the hex color value in the custom color picker', async () => {
HsvColorPicker.mockImplementation( ( props ) => {
return <Pressable { ...props } testID="hsv-color-picker" />;
} );
const screen = await initializeEditor( {
initialHtml: COVER_BLOCK_PLACEHOLDER_HTML,
} );

// Select a color from the placeholder palette.
const colorButton = screen.getByA11yHint(
'Navigates to custom color picker'
);
fireEvent.press( colorButton );

// Wait for Block Settings to be visible.
const blockSettingsModal = screen.getByTestId( 'block-settings-modal' );
await waitForModalVisible( blockSettingsModal );

// Assert label text before tapping color picker
expect( screen.getByText( 'Select a color' ) ).toBeVisible();

// Tap color picker
const colorPicker = screen.getByTestId( 'hsv-color-picker' );
fireEvent( colorPicker, 'onHuePickerPress', {
hue: 120,
saturation: 12,
value: 50,
} );

// Assert label hex value after tapping color picker
expect( screen.getByText( '#00FF00' ) ).toBeVisible();
} );
} );

describe( 'minimum height settings', () => {
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/src/missing/edit.native.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ export class UnsupportedBlockEdit extends Component {
styles.unsupportedBlockSubtitle,
styles.unsupportedBlockSubtitleDark
);

const subtitle = (
<Text style={ subTitleStyle }>{ __( 'Unsupported' ) }</Text>
);
Expand Down
13 changes: 7 additions & 6 deletions packages/react-native-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ For each user feature we should also add a importance categorization label to i
-->

## Unreleased
- [*] Display custom color value in mobile Cover Block color picker [#51414]
- [*] Remove visual gap in mobile toolbar when a Gallery block is selected [#52966]
- [*] Remove Gallery caption button on mobile [#53010]
- [**] Upgrade React Native to 0.71.11 [#51303]
Expand All @@ -21,8 +22,8 @@ For each user feature we should also add a importance categorization label to i
- [**] Add media inserter buttons to editor toolbar [#51827]
- [**] Update native BlockOutline component styles to remove blue border from blocks [#51222]
- [**] Move the undo/redo buttons to the navigation bar [#51766]
- [**] Update Editor block inserter button styles and default text input placeholder/selection styles [#52269]
- [**] Update Editor toolbar icons and colors [#52336]
- [**] Update Editor block inserter button styles and default text input placeholder/selection styles [#52269]
- [**] Update Editor toolbar icons and colors [#52336]
- [*] Update Block Settings button border [#52715]

## 1.99.1
Expand Down Expand Up @@ -70,7 +71,7 @@ For each user feature we should also add a importance categorization label to i
- [**] Fix regression with the Color hook and ColorPanel. [#49917]

## 1.93.0
- [***] [iOS] Fixed iOS scroll jumping issue by refactoring KeyboardAwareFlatList improving writing flow and caret focus handling. [#48791]
- [***] [iOS] Fixed iOS scroll jumping issue by refactoring KeyboardAwareFlatList improving writing flow and caret focus handling. [#48791]

## 1.92.1
- [*] Avoid empty Gallery block error [#49557]
Expand Down Expand Up @@ -565,8 +566,8 @@ For each user feature we should also add a importance categorization label to i
## 1.42.0

- [***] Adding support for selecting different unit of value in Cover and Columns blocks [#26161]
- [**] Button block - Add link picker to the block settings [#26206]
- [**] Support to render background/text colors in Group, Paragraph and Quote blocks [#25994]
- [**] Button block - Add link picker to the block settings [#26206]
- [**] Support to render background/text colors in Group, Paragraph and Quote blocks [#25994]
- [*] Fix theme colors syncing with the editor [#26821]
- [**] Fix issue where a blocks would disappear when deleting all of the text inside without requiring the extra backspace to remove the block. [#27583]

Expand Down Expand Up @@ -861,4 +862,4 @@ For each user feature we should also add a importance categorization label to i
## 1.6.0

- Fixed issue with link settings where “Open in New Tab” was always OFF on open.
- Added UI to display a warning when a block has invalid content.
- Added UI to display a warning when a block has invalid content.
2 changes: 2 additions & 0 deletions test/native/__mocks__/styleMock.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,4 +202,6 @@ module.exports = {
embed__icon: {
fill: 'black',
},
picker: {},
pickerPointer: {},
};
8 changes: 5 additions & 3 deletions test/native/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,11 @@ jest.mock( 'react-native-linear-gradient', () => () => 'LinearGradient', {
virtual: true,
} );

jest.mock( 'react-native-hsv-color-picker', () => () => 'HsvColorPicker', {
virtual: true,
} );
jest.mock(
'react-native-hsv-color-picker',
() => jest.fn( () => 'HsvColorPicker' ),
{ virtual: true }
);

jest.mock( '@react-native-community/blur', () => () => 'BlurView', {
virtual: true,
Expand Down
Loading