Edit Site: Refactor the NavigationMenuContent component and fix the deprecation notice #51469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -132 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Wow this is such a great improvement. I'd not had a chance to dive in there and this produces a much better UX. Thank you! I'll review tomorrow. |
getdave
approved these changes
Jun 14, 2023
|
Thanks for the review/testing, @getdave! |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…eprecation notice (WordPress#51469) * Edit Site: Refactor the NavigationMenuContent component and fix the deprecation notice * Remove artificial delay to avoid loading flickering * Display Page List block when it has no inner blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes
blocksproperty deprecation notice for Navigation menus in the Site Editor sidebar and refactors selectors to work with therootClientIdprop.I've also removed the artificial loading delay. The original flickering issue isn't noticeable now that the "skeleton" loader has been removed (#50326).
What is causing the "flickering:"
The list view starts rendering the
rootClientIdblocks while the "is single list block" value is resolved and then switches to rendering page list items. You can test this by logging the following condition:Why?
The core shouldn't use deprecated properties/methods.
How?
Updates the
PrivateListViewcomponent torootClientIdinstead of theblocksprop.Testing Instructions
First, please ensure the testing site has at least one Navigation menu with custom links/pages and one showing "Page List."
Screenshots or screencast
CleanShot.2023-06-13.at.20.42.41.mp4