Global styles revisions: move from experimental to 6.3 #51474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not required for 6.3 and was unrelated to the addition of the /revisions endpoint in the first place Moving global styles revisions endpoint file to 6-3 since it'll be included in 6.3 and is not experimental
ramonjd
added
[Type] Code Quality
ramonjd
requested review from
noisysocks,
apeatling,
tellthemachines and
andrewserong
|
Flaky tests detected in abad5d9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5262111962
|
ramonjd
commented
Jun 14, 2023
| */ | ||
| function gutenberg_update_global_styles_rest_controller( $args, $post_type ) { | ||
| if ( in_array( $post_type, array( 'wp_global_styles' ), true ) ) { | ||
| $args['rest_controller_class'] = 'Gutenberg_REST_Templates_Controller_6_3'; |
There was a problem hiding this comment.
LOL Gutenberg_REST_Templates_Controller_6_3 was way off 😮💨
… endpoint test :)
andrewserong
approved these changes
Jun 14, 2023
17 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Removing `gutenberg_update_global_styles_rest_controller` hook as it's not required for 6.3 and was unrelated to the addition of the /revisions endpoint in the first place Moving global styles revisions endpoint file to 6-3 since it'll be included in 6.3 and is not experimental * Class needs to be named after file name, hence the 6_3 suffix * Backporting changes from core to gutenberg: adding prepare_date_response to parse dates * Tearing down after class in tests * Post name should be different to the one created in the global styles endpoint test :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not require backporting to Core - shuffling files in Gutenberg and backporting from core changes in WordPress/wordpress-develop#4606 only
What and why?
gutenberg_update_global_styles_rest_controllerhook as its not required for 6.3 and was unrelated to the addition of the global styles /revisions endpoint in the first place. (Introduced in Rest API: add /revisions endpoint for global styles #49974)prepare_date_responseto parse dates (From Rest API: add /revisions endpoint for global styles wordpress-develop#4606)Testing
Tests should pass as expected