npm lockfile: hoist reakit and date-fns packages to the top #51500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -26 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Jun 15, 2023
jsnajdr
force-pushed
the
update/hoist-reakit-date-fns
branch
from
20df31d
to
f32927a
Compare
Pushed a commit that does that, and also |
|
Flaky tests detected in f32927a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5281265847
|
Sounds great, thanks again! |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…s#51500) * npm lockfile: hoist reakit and date-fns packages to the top * Dedupe deepmerge * Dedupe colord
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at output of
npm run build:analyze-bundles, I noticed that our lockfile installs thereakitanddate-fnspackages into suboptimalpackages/components/node_modulesdirectory instead of the top-levelnode_moduleswhere they should be. The top-levelreakitslot is free, there is no conflict with any other package. And thedate-fnsslot was occupied by old 1.x version used byconcurrently, while all other packages use 2.x and are forced to install their own copies, duplicated many times over.This PR fixes that. Before it, the
componentspackage had its 3rd party dependencies in two directories:while now all dependencies are neatly sorted in one directory:
You can see clearly, for example, that
reakitis the third largest dependency afterframer-motionandradix-ui.