Bugfix/command centre accessibility issue #51521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e button text to reflect what button does
…isible focus style
|
Before making the name of the feature visible in the UI, I think we need a final decision about what to call it: |
|
PR is now very stale, UI has changed a lot. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixed accessibility issues and html validation issues from site-editor top bar. Made sure button has clear :focus styles
Why?
Issue was brought up by #51460
How?
Moved "Current template" name from the button to before it. Changed button label to reflect what the button actually does.
I am not satisfied that I set h1 (Current template name) as visually hidden. But it simply does not fit in smaller screens.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast