Block Locking: Fix regression in selectors #51541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
youknowriad and
noisysocks
and removed request for
ellatrix
Mamaduka
added
[Type] Regression
|
Size Change: +5 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8bad90c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5279824324
|
noisysocks
approved these changes
Jun 16, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Block Locking: Fix regression in selectors * A minor adjustments to the e2e tests * Add e2e tests for block locking and template lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Regression was introduced in #51148.
PR fixes a regression when blocks were not able to override the
templateLockvia Block Locking API.Why?
Block locking should supersede template locking. See https://make.wordpress.org/core/2022/01/08/locking-blocks-in-wordpress-5-9/.
How?
When the
attributes.lockvalue isn'tundefinedreturn early.Testing Instructions
I added e2e test coverage to catch regressions early. See 8bad90c.
Snippet