Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Library panel footer #51652

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Update Library panel footer #51652

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
746f0f4
Update button, add radius
jameskoster Jun 19, 2023
6a6383c
Manage template parts
jameskoster Jun 19, 2023
4ec3915
Reinstate 'all'
jameskoster Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/edit-site/src/components/sidebar-navigation-item/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
padding: $grid-unit-10 6px $grid-unit-10 $grid-unit-20;
border: none;
min-height: $grid-unit-50;
border-radius: $radius-block-ui;

&:hover,
&:focus,
Expand All @@ -22,6 +23,8 @@

&:is(a) {
text-decoration: none;
display: flex;
align-items: center;

&:focus {
box-shadow: none;
Expand Down
3 changes: 1 addition & 2 deletions packages/edit-site/src/components/sidebar-navigation-screen-templates/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const config = {
title: __( 'Library' ),
loading: __( 'Loading library' ),
notFound: __( 'No patterns found' ),
manage: __( 'Manage all template parts' ),
manage: __( 'Manage template parts' ),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like shorter, but since you're already seeing TPs in the library, is this actually clearer? Not a strong opinion, but why would I want to click "Manage template parts" if I can already see them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm good point.

I suppose it depends how you read it. For me the onus is on 'manage' rather than 'all'. So to answer your question: you'd click if you want to manage what you can see. IE quickly delete / rename a bunch of template parts. From that perspective 'all' is kind of implied – you wouldn't jump directly into managing only a portion of template parts.

That said, I notice we currently have "Manage all templates" in the Templates panel 🙈 So perhaps we leave this one change out for now.

reusableBlocks: __( 'Manage reusable blocks' ),
description: __(
'Template Parts are small pieces of a layout that can be reused across multiple templates and always appear the same way. Common template parts include the site header, footer, or sidebar.'
Expand Down Expand Up @@ -161,7 +161,6 @@ export default function SidebarNavigationScreenTemplates() {
<SidebarNavigationItem
as="a"
href="edit.php?post_type=wp_block"
withChevron
>
{ config[ postType ].labels.reusableBlocks }
</SidebarNavigationItem>
Expand Down
Loading