Site editor sidebar: add footer to template part and ensure nested template areas display #51669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- performs `lastModifiedDateTime` check in the generic footer - adds a last modified footer to template parts - ensures we know which default template part areas a template is using, even if those template areas are nested
ramonjd
added
[Type] Enhancement
logs of change
|
Size Change: -40 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Thanks for the quick follow-up! The fixes here are testing well for me, but I noticed a spacing issues with the details area on the Pages screen. I've added a comment on the previous PR over in https://github.com/WordPress/gutenberg/pull/51223/files#r1234679009, but I was wondering if we can fix up the spacing here in this PR, too? Looks like it might be a matter of passing down spacing={ 5 } where we need it?
From a quick look, it might just need to be added on this line:
🤔
andrewserong
approved these changes
Jun 20, 2023
Done in 1594b4f. Thanks for picking that up. I'd prepared the prop in the new component but forgot to reinstate it in PageDetails. 😵💫 |
No worries, easy to miss when refactoring things! 🙂 |
|
Flaky tests detected in 1594b4f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5318100138
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…mplate areas display (WordPress#51669) * This commit: - performs `lastModifiedDateTime` check in the generic footer - adds a last modified footer to template parts - ensures we know which default template part areas a template is using, even if those template areas are nested * cha cha chaaaaaaange logs of change * Adding spacing to page details
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This commit is a follow up to:
lastModifiedDateTimecheck in the generic footerKudos to @andrewserong for raising most of the points that this PR addresses.
Why?
SidebarNavigationScreenDetailsFooteris a generic component and therefore should handle internally whether is constituent parts are renderedTesting Instructions
Screenshots or screencast
See last updated footer in templates and template parts
See the template's template areas