Use interactivity API for Navigation and File blocks only in Gutenberg #51694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Block] File
|
Size Change: +9.74 kB (+1%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7933cea. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5322144280
|
|
I get this PHP notice. 😢
I think you need to filter by block name, or it will try to do it an all blocks. |
cbravobernal
requested changes
Jun 20, 2023
|
I tested and works as expected. |
luisherranz
approved these changes
Jun 20, 2023
cbravobernal
approved these changes
Jun 20, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
WordPress#51694) * Add conditional to navigation block * Add conditional to file block * Skip `view-modal` if `should_load_script` is false * Fix typo * Apply conditional in `block_type_metadata` filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a conditional to only use the Interactivity API in the Navigation and File blocks only when Gutenberg is activated.
Why?
As the Interactivity API version won't be included in WordPress yet, we need this conditional so it uses the previous version in WordPress but it uses the Interactivity API if Gutenberg is activated.
How?
I reverted the changes made in this pull request, adding back the old
view.jsfiles, and usedefined( 'IS_GUTENBERG_PLUGIN' ) && IS_GUTENBERG_PLUGINto use the Interactivity API dynamically. Basically, if Gutenberg is activated, it is:viewScriptfile tointeractivity.jsthrough theblock_type_metadatafilter.If Gutenberg is not activated, it is using the previous JS files and the attributes used by Micromodal.
I kept the logic added in the mentioned pull request to dynamically load the scripts because I believe it applies to both cases. If I am not mistaken, in the current version of WordPress, the scripts are always loaded even if they are not needed. So it should be an improvement although it is not perfect.
Testing Instructions
We can simulate it by toggling this variable. For both the Navigation and File blocks we have to check:
When
IS_GUTENBERG_PLUGINis false:view.jsfiles are loaded.interactivity.js,vendors.js, andruntime.js).Show inline embedis activated, it should show a preview only on desktop and not on mobile.When
IS_GUTENBERG_PLUGINis true:view.jsfiles are NOT loaded.Show inline embedis activated, it should show a preview only on desktop and not on mobile.