Patterns: add a hint about the rename of reusable blocks to menu and inserter #51771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Feature] Synced Patterns
glendaviesnz
requested review from
spacedmonkey,
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: +435 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2c9384b8a1d1ed0af12258483de3a3b1b47eae7b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5460465659
|
SaxonF
reviewed
Jun 22, 2023
...s/reusable-blocks/src/components/reusable-blocks-menu-items/reusable-block-convert-button.js
Outdated
Show resolved
Hide resolved
|
I like the sentiment but I’m not sure it’s the right solution, at least the MenuItem label. |
Do you have any alternative solutions? The theory is that the menu label would only be there for one release cycle. |
|
I'm also not sure about this, feels a little confusing. I'd personally prefer something more like a "What's new" guide for existing users. Some previous discussion here about that - #22241 |
|
Can we do this instead? 
|
I think this approach will work really well if it's possible to implement. |
|
That transition for existing users is an excellent idea! The renaming is certainly a factor, but explained right it actually reduces cognitive load for users in the long run and the outlook that there will be partially synched pattern in the future will excite many users, too. |
glendaviesnz
changed the title
SaxonF
approved these changes
Jun 23, 2023
|
I think the hint will need an accessibility review. Typically there are pretty strong semantics about menus/menu items, and this adds a random button into the middle of a menu. The good thing is that keyboard navigation still seems to work ok. Though currently when you navigate through the menu, all the items are read out like this:
I wonder if the button label might make it seem like it dismisses the menu. It might be ok, but would appreciate if someone more knowledgable could check it. An alternative option might be to make it so that the 'Dismiss' button can't be reached through keyboard navigation, and instead use an aria-description on the 'Create pattern' menu item to inform about the renaming of reusable blocks. |
glendaviesnz
force-pushed
the
try/keeping-reusable-block-name
branch
from
5869473
to
8f9158d
Compare
glendaviesnz
force-pushed
the
try/keeping-reusable-block-name
branch
from
8f9158d
to
6582fb5
Compare
|
@alexstine It would be good to get this into 16.2 if we can, so if you had time to look at it that would be great. FYI, this is just temporary, with the idea that it would only be in the 6.3 release and then removed in 6.4. |
glendaviesnz
added
the
Backport to WP 6.7 Beta/RC
|
@glendaviesnz Why would this only need to stick around for 1 release? The UX here are pretty bad for screen readers. This is misuse of a notice to place it in the DOM of a menu. If this goes out, I would label this type regression and type bug. Is there a way this can be communicated to users without making a UI mess? I'm going to say something many of you might not like. If users need hints, maybe it is not as clear as it should be. I find this area of Gutenberg very confusing. The goal of course is to improve things to prevent confusion but if hints are still needed to guide users, maybe this goal is not being met. I recommend this menu modification goes no further. Thanks. |
Thanks for the quick reply @alexstine. I did suggest that we just have the menu label as
The intention is for it to ease the transition between the rename of reusable blocks to patterns. |
glendaviesnz
force-pushed
the
try/keeping-reusable-block-name
branch
from
e3f8b21
to
55e83d2
Compare
glendaviesnz
force-pushed
the
try/keeping-reusable-block-name
branch
from
2c9384b
to
2c6a34a
Compare
tellthemachines
pushed a commit
that referenced
this pull request
Jul 7, 2023
…inserter (#51771) Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>
|
I just cherry-picked this PR to the update/first-pre-beta-4 branch to get it included in the next release: 14bb146 |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
added a commit
that referenced
this pull request
Jul 7, 2023
* add hint to show template part move (#52395) * Page Content Focus: Ignore page content within a Query Loop block (#52351) * Block Editor: Pass context and className props to editor.BlockEdit filter * Page Content Focus: Ignore content blocks that are within a Query Loop * Patterns: stop endless snackbars appearing (#52012) * Patterns: Distinguish between theme patterns and template parts in category list (#52382) * Allow opt out of auto-creation of Navigation fallback (#52319) * Update welcome guide copy (#52282) * Patterns: Update pattern copy (#52340) * Post Title: The changes should be reflected when previewing a post (#52369) * Update fixed block toolbar (#52123) * update the icons for expanding and collapsing the fixed block toolbar * hide the tools selector item in document tools for fixed toolbar preference * reveal undo, redo and list view buttons * tweaks for show icon labels and hide zoom out for top toolbar option * improve the responsiveness of the fixed block toolbar * remove the overflow rule - bad experiment * update top toolbar test with the new label for buttons * update the toolbar tests to account for moving the collapse button * Drop PHP 5.6 CI jobs (#52345) * Remove PHP 5.6 PHPUnit CI job * Raise version in phpcs / WPCS * Patterns: Add handling of sync status to the wp-admin patterns list page (#52346) * Exit template focus when opening the W menu (#52235) * wrap buttons (#52249) * Update the behavior of the cached undo/redo stack (#51644) Co-authored-by: Ella van Durpe <ella@vandurpe.com> * Adjust top position (#52248) * Patterns: add a hint about the rename of reusable blocks to menu and inserter (#51771) Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> * Site Editor: update headings hierarchy in the 'Manage all' screens (#52271) * This commit: - updates heading levels on the template and template part pages - passes a `level` prop to Header from Page * update h2 size * Rolling back custom sizes * Rolling back unnecessary classNames There was a rogue space in trunk. Let's let it live * Check randomizer experiment is enabled before rendering button (#52306) * Hide parent selector when parent is 'disabled' or 'contentOnly' (#52264) * Fix incorrect aria-describedby attributes for theme patterns (#52263) * Patterns: rename sync_status and move to top level field on rest return instead of a meta field (#52146) * Fix default block dimensions visibility (#52256) * core/heading * core/details * core/list * core/table * core/video * core/verse * core/social-links * core/site-title * core/site-tagline * core/site-logo * core/post-time-to-read * core/gallery * core/code * core/categories * core/audio * core/archives * Patterns: Display all custom template part areas in sidebar nav (#52355) * Revert phpcs back to PHP 5.6 (#52384) Reverts phpcs PHP compatibility version back to 5.6. * Check if experiment enabled fr this time (#52315) * Navigation: Remove one preloaded endpoint (#52115) * default to showing status (#52226) * Command palette: rename (#52153) * Revise use of “command menu” to “command palette”. Dropping "global" where it was used as well. * Find “command center” and replace with “command palette” * Image block and behaviors: Fix some warnings (#52109) * Fix first warning * Fix second warning - dividing a NaN * Turn off DFM for style book and style editing (#52117) * Add confirmation step when deleting a Template (#52236) * [Command Palette]: Remove suggestion for deleting templates/parts (#52168) * Update stepper styling in Home template details panel (#51972) * Update stepper styling * Remove !important * [Edit Post]: Add toggle fullscreen mode and list view commands (#52184) * Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu (#52222) * Style Book: Show tabs and make blocks clickable when entering edit mode from the Styles menu * Move lines * !important (#52025) * Navigation in Site View: Readd the edit button (#52111) * Fix UnitControl crashing on regex control characters. Units are now escaped using `escapeRegExp` before concatenating them into a regular expression. Fixes #52211. --------- Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> * Patterns: rename wp_block sync_status postmeta to wp_pattern_sync_status (#52232) --------- Co-authored-by: Kai Hao <kai@kaihao.dev> * Site Editor Frame: Ignore Spotlight in view mode (#52262) * Guide: Place focus on the guide's container instead of its first tabbable (#52300) * Guide: Place focus on the guide's container instead of its first tabbable * Update CHANGELOG * Post editor: Require confirmation before removing Footnotes (#52277) * Post editor: Require confirmation before removing Footnotes Context: #52176 * BlockRemovalWarningModal: Limit width to 40rem * Explain that footnotes are preserved. Add warning to Site Editor * Fix react-dropdown-menu version to avoid breaking change from one of … (#52356) * Fix react-dropdown-menu version to avoid breaking change from one if its dependencies. * Changelog update * move changelog entry to the right place * Update package-lock --------- Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Co-authored-by: Tonya Mork <tonya.mork@automattic.com> Co-authored-by: Riad Benguella <benguella@gmail.com> Co-authored-by: Ella van Durpe <ella@vandurpe.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Ben Dwyer <ben@scruffian.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com> Co-authored-by: Nik Tsekouras <ntsekouras@outlook.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Timothy Jacobs <timothy@ironbounddesigns.com> Co-authored-by: Kai Hao <kai@kaihao.dev> Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com>
|
@jasmussen maybe a different one, but would it make sense to reduce the icons (which are passive hints I believe) to be less prominent resulting in a more focused list. The notice could also have less prominence, be more like a subcopy of the label that eventually will disappear but stays there for a while to reinforce the learning. |
92 tasks
@pablohoneyhoney unfortunately @jasmussen's suggestion of adding the notice to the menu had accessibility issues, so we didn't take that idea any further. |
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a hint to the menu and tab inserter to alert users to rename of reusable blocks
Why?
To help users with the transition
How?
Uses the existing preferences infrastructure to allow hint to be dismissed
Testing Instructions
Create pattern/reusable blockSynced patternstab check that the hint also showsKeyboard Testing Instructions
Screenshots or screencast
hint.mp4