Page Content Focus: Default insertion point to the Post Content block #51773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Bug
|
Size Change: +71 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 04047c6777639d0654f11eb1dfaef0537171787c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5340628144
|
SaxonF
reviewed
Jun 22, 2023
There was a problem hiding this comment.
Work well for me in testing and is a big improvement over what we have. In future we may want to also consider adopting this behaviour even if blocks outside the post content block are selected (e.g. featured image).
If someone else can give the thumbs up on code LGTM
apeatling
approved these changes
Jun 22, 2023
tellthemachines
force-pushed
the
fix/page-content-focus-inserter
branch
from
04047c6
to
6a936ff
Compare
noisysocks
added
the
[Feature] Page Content Focus
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…WordPress#51773) * Page Content Focus: Default insertion point to the Post Content block * Don't prioritise patterns if there is a specified root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follows #50857.
Makes it so that when you are focused on editing a page's content in the site editor and no block is selected, the global inserter will insert blocks into the end of the Post Content block.
Why?
This mimics the post editor and is what users would expect when editing page content.
How?
Adds a special case to the existing
__experimentalGetInsertionPointselector in thecore/edit-sitestore.Testing Instructions
Screenshots or screencast
Kapture.2023-06-22.at.11.35.40.mp4