Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Introduce size prop #51842

Merged
merged 12 commits into from
Jun 23, 2023
Merged

Button: Introduce size prop #51842

merged 12 commits into from
Jun 23, 2023

Commits on Jun 22, 2023

  1. Revert "Button: Add opt-in prop for larger isSmall size (#51012)" 

    This reverts commit 19bcabf.

# Conflicts:
#	packages/components/CHANGELOG.md
    @mirka
    mirka committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b992cbe View commit details
    Browse the repository at this point in the history

  2. Add docs for size prop 

    Also fixes type duplicate prop name issues in NumberControl and FontSizePicker
    @mirka
    mirka committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    5f1f4a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Add CSS

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    82cff38 View commit details
    Browse the repository at this point in the history

  2. Fixup

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    5446c80 View commit details
    Browse the repository at this point in the history

  3. Add TODO for deprecation

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    9f703d6 View commit details
    Browse the repository at this point in the history

  4. Add test for back compat

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ae12f01 View commit details
    Browse the repository at this point in the history

  5. Fixup

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    400a02b View commit details
    Browse the repository at this point in the history

  6. Add changelog

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ccbd9da View commit details
    Browse the repository at this point in the history

  7. Tweak description for "compact"

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    47bc0ea View commit details
    Browse the repository at this point in the history

  8. Note that the size prop takes precedence

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    d03ba97 View commit details
    Browse the repository at this point in the history

  9. Add test for prop priority

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    9ec488a View commit details
    Browse the repository at this point in the history

  10. Stop leaking spinButtonSize prop for styling

    @mirka
    mirka committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    590964c View commit details
    Browse the repository at this point in the history