Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest API: rename navigation fallback classes from WP_ to Gutenberg_ #51959

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Rest API: rename navigation fallback classes from WP_ to Gutenberg_ #51959

merged 5 commits into from
Jun 27, 2023

Commits on Jun 27, 2023

  1. The WP_REST_Navigation_Fallback_Controller class has been committed… 

    … to core and therefore results in a naming conflict and unit test failures.

Ideally `WP_REST_Navigation_Fallback_Controller` should have been named `WP_REST_Navigation_Fallback_Controller_Gutenberg` and extended `WP_REST_Navigation_Fallback_Controller`.
But we can conditionally load the file instead.
    @ramonjd
    ramonjd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    87c4e6c View commit details
    Browse the repository at this point in the history

  2. Renamed WP_Classic_To_Block_Menu_Converter to Gutenberg_Classic_To_Bl… 

    …ock_Menu_Converter

Load WP_REST_Navigation_Fallback_Controller dependencies in load.php
    @ramonjd
    ramonjd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    ee38a17 View commit details
    Browse the repository at this point in the history

  3. Renamed all 6.3 classes to have the Gutenberg_ prefix. This should av… 

    …oid compat errors and hopefully some confusion later.
    @ramonjd
    ramonjd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    007f7fe View commit details
    Browse the repository at this point in the history

  4. Also rename test files for completeness

    @ramonjd
    ramonjd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f09b261 View commit details
    Browse the repository at this point in the history

  5. Updated deprecation notices to refer to Gutenberg classes

    @ramonjd
    ramonjd committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f548e99 View commit details
    Browse the repository at this point in the history