Navigation: Add the draft status to the navigation title #51967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.94 kB (0%) Total Size: 1.45 MB
ℹ️ View Unchanged
|
getdave
reviewed
Jun 27, 2023
...dit-site/src/components/sidebar-navigation-screen-navigation-menus/build-navigation-label.js
Outdated
Show resolved
Hide resolved
getdave
reviewed
Jun 27, 2023
| import { __, sprintf } from '@wordpress/i18n'; | ||
| import { decodeEntities } from '@wordpress/html-entities'; | ||
|
|
||
| // Copied from packages/block-library/src/navigation/edit/navigation-menu-selector.js. |
There was a problem hiding this comment.
This is tracked here #51446
getdave
reviewed
Jun 27, 2023
Comment on lines
+33
to
+35
| navigationMenu?.title, | ||
| navigationMenu?.id, | ||
| navigationMenu?.status |
There was a problem hiding this comment.
This is starting to seem strange. It's like we should just pass the entire Post 😄
There was a problem hiding this comment.
I did wonder that too
getdave
reviewed
Jun 28, 2023
Comment on lines
+8
to
+24
| export default function buildNavigationLabel( title, id, status ) { | ||
| if ( ! title?.rendered ) { | ||
| /* translators: %s is the index of the menu in the list of menus. */ | ||
| return sprintf( __( '(no title %s)' ), id ); | ||
| } | ||
|
|
||
| if ( status === 'publish' ) { | ||
| return decodeEntities( title?.rendered ); | ||
| } | ||
|
|
||
| return sprintf( | ||
| // translators: %1s: title of the menu; %2s: status of the menu (draft, pending, etc.). | ||
| __( '%1$s (%2$s)' ), | ||
| decodeEntities( title?.rendered ), | ||
| status | ||
| ); | ||
| } |
There was a problem hiding this comment.
Not for now but I wonder if in future we could define some of these defaults centrally in packages/core-data/src/entities.js and avoid having to repeat ourselves.
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…1967) * Navigation: Add the draft status to the navigation title * Move the buildNavigationLabel function to the default export
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the
(draft)status to the title of the Navigation area of the Site View sidebar. Fixes #51797.Why?
The status should be in both places.
How?
Extract
buildNavigationLabelto a new file so it can be shared across all the different places it is used.Testing Instructions
(draft)status indicator next to it in both the list view and the single view.Screenshots or screencast