-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide word count and reading time meta data for the Posts Page details panel #52186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanfra
added
[Type] Bug
An existing feature does not function as intended
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
labels
Jun 30, 2023
Size Change: +1.04 kB (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my small comment, this looks good. Thanks @juanfra !
packages/edit-site/src/components/sidebar-navigation-screen-page/page-details.js
Outdated
Show resolved
Hide resolved
ntsekouras
approved these changes
Jul 3, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
Needs User Documentation
Needs new user documentation
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hide word count and reading time metadata for the Posts Page details panel.
Fixes: #51260
Why?
Since the Posts Page (defined in reading settings) will always render a template rather than displaying a page, there is no reference for word count or reading time.
Testing Instructions
Screenshots or screencast
Screen.Recording.2023-06-30.at.17.08.42.mov