Migrate site editor multi-entity save flow tests #52372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
added
[Type] Bug
Mamaduka
commented
Jul 6, 2023
Comment on lines
-272
to
-278
| // Select the header template part via list view. | ||
| await page.click( '.edit-site-header-edit-mode__list-view-toggle' ); | ||
| const headerTemplatePartListViewButton = await page.waitForXPath( | ||
| '//a[contains(@class, "block-editor-list-view-block-select-button")][contains(., "header")]' | ||
| ); | ||
| headerTemplatePartListViewButton.click(); | ||
| await page.click( 'button[aria-label="Close"]' ); |
There was a problem hiding this comment.
This step wasn't relevant to the tests, so I omitted it from migration.
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 7c5755c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5476935542
|
| .getByRole( 'button', { name: 'Open save panel' } ) | ||
| ).toBeVisible(); | ||
|
|
||
| await editor.saveSiteEditorEntities(); |
There was a problem hiding this comment.
Should we delete template parts before/after the tests to avoid the changes to persist between tests?
There was a problem hiding this comment.
A good idea. Added the template cleanup to the tests since we only change the templates now.
MaggieCabrera
approved these changes
Jul 6, 2023
|
Thank you, @MaggieCabrera 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates Site Editor parts of
specs/site-editor/multi-entity-saving.test.jse2e test to Playwright.Why?
specs/site-editor/multi-entity-saving.test.jstest has been failing a lot lately. The Puppeteer artifacts aren't helpful with debugging, and Playwright tests are more stable, in my experience.editorandsite-editortests separately, I decided to split the test and migration efforts.Recent failures
Testing Instructions
CI checks are green, and puppies are happy 🐶
Puppeteer artifact
Based on this screenshot, a selected block is a paragraph but renders the Excerpt block controls. I am unsure how the tests ended in this block editor state.