Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try forward slash keyboard shortcut for command palette #52386

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Try forward slash keyboard shortcut for command palette #52386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a2f4f8
Deconflict shortcut for command palette
stokesman Jun 30, 2023
fdc0850
Update displayed shortcut in editors
stokesman Jun 30, 2023
de6a894
Change alias to F1
stokesman Jul 14, 2023
8322fdd
Remove ineffectual argument
stokesman Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/commands/src/components/command-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,9 @@ export function CommandMenu() {
description: __( 'Open the command palette.' ),
keyCombination: {
modifier: 'primary',
character: 'k',
character: '/',
},
aliases: [ { character: 'F1' } ],
} );
}, [ registerShortcut ] );

Expand All @@ -221,9 +222,6 @@ export function CommandMenu() {
} else {
open();
}
},
{
bindGlobal: true,
}
);

Expand Down
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/site-hub/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ const SiteHub = memo( ( { isTransparent, className } ) => {
icon={ search }
onClick={ () => openCommandCenter() }
label={ __( 'Open command palette' ) }
shortcut={ displayShortcut.primary( 'k' ) }
shortcut={ displayShortcut.primary( '/' ) }
/>
) }
</HStack>
Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/components/document-bar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function BaseDocumentActions( { postType, postId, onBack } ) {
</Text>
</HStack>
<span className="editor-document-bar__shortcut">
{ displayShortcut.primary( 'k' ) }
{ displayShortcut.primary( '/' ) }
</span>
</Button>
) }
Expand Down
Loading